Repository navigation
fix(io): route wrapped local file IO through the selected store - #11221
Merged
Merged
Conversation
This was referenced Nov 18, 2026
Xuanwo
marked this pull request as ready for review
November 18, 2026 10:09
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
Using the existing object-store path for wrapped handles addresses the local I/O interception problem. Keeping direct access as a capability of unwrapped built-in file stores is a reasonable boundary for this focused fix.
BubbleCal
approved these changes
Nov 18, 2026
Xuanwo
added a commit
that referenced
this pull request
Nov 18, 2026
…name (#11220) First of six draft changes to the Lance storage API, based on c377b70. Local conditional writes stage beside the destination using a fixed-length basename. Construct the sibling from the parsed parent to preserve encoded path components. The existing conditional rename, conflict result, and cleanup behavior are preserved. The local regression writes twice under a non-ASCII parent using a 241-byte basename and checks that the original bytes survive the conflict. The two put-if-absent cases and workspace Clippy also passed with this patch applied to main at 134c2bf. Main already preserves parent encoding for namespace marker staging. **Storage stack (1/6)** · #11220 → #11221 → #11223 → #11225 → #11226 → #11227 The six commits preserve the reviewed tree based on `c377b70b6`. Layer 1 also passed its targeted tests and workspace Clippy on main at `134c2bf95`. Integrating the later layers with newer main changes to S3 markers, cleanup and shallow clones remains separate work.
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Xuanwo
added a commit
that referenced
this pull request
Nov 18, 2026
…#11234) Rust CI is red on main in `lance-io`: `test_object_store_selects_scheduler` fails on Linux, macOS and Windows at `assertion failed: uring_store.prefers_lite_scheduler()`. #11221 made direct local I/O a provider declaration, so the lite scheduler preference now follows what the store will actually do. The test built its uring store with the legacy `ObjectStore::new`, which never declares that mapping, and it asserted the preference on platforms where the `file+uring` provider is not registered. Build the store with `ObjectStore::from_uri`, the path real callers use, and keep the uring assertions where the scheme exists (Linux). The memory-store preference and the explicit `Some(true)` override still run on every platform; no runtime behavior changes. Validated on Linux with the `ci` profile: `lance-io` library tests (700 passed, including the previously failing test) and workspace Clippy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #11220.
A wrapper installed by the registry or on an existing handle must see local file reads, writes and copies, including external blob reads. Keep native directory maintenance available on built-in file stores. Track the ordinary and external views once at assembly so later wrappers retain their existing relationship to the tracker.
Verified 113 lance-io object store tests, including local, file-object-store and Linux io_uring with registry and late wrappers. Workspace Clippy passed for tests and benches.
Storage stack (2/6) · #11220 → #11221 → #11223 → #11225 → #11226 → #11227