Skip to content

test(io): select the lite scheduler from a provider-built uring store - #11234

Merged
Xuanwo merged 1 commit into
mainfrom
xuanwo/fix-lite-scheduler-selection-test
Nov 18, 2026
Merged

Xuanwo merged 1 commit into
mainfrom
xuanwo/fix-lite-scheduler-selection-test

Conversation

@Xuanwo

@Xuanwo Xuanwo commented Nov 18, 2026

Copy link
Copy Markdown
Member

Rust CI is red on main in lance-io: test_object_store_selects_scheduler fails on Linux, macOS and Windows at assertion failed: uring_store.prefers_lite_scheduler().

#11221 made direct local I/O a provider declaration, so the lite scheduler preference now follows what the store will actually do. The test built its uring store with the legacy ObjectStore::new, which never declares that mapping, and it asserted the preference on platforms where the file+uring provider is not registered.

Build the store with ObjectStore::from_uri, the path real callers use, and keep the uring assertions where the scheme exists (Linux). The memory-store preference and the explicit Some(true) override still run on every platform; no runtime behavior changes.

Validated on Linux with the ci profile: lance-io library tests (700 passed, including the previously failing test) and workspace Clippy.

Direct local I/O is a provider declaration since #11221, so a store built
with the legacy ObjectStore::new no longer performs io_uring reads. Build
the store through the registry like real callers do and assert the uring
preference only where the file+uring provider is registered.

Fixes the Rust CI failure in test_object_store_selects_scheduler, which
failed on Linux, macOS and Windows.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@github-actions github-actions Bot added A-encoding Encoding, IO, file reader/writer chore labels Nov 18, 2026

@lance-gatekeeper lance-gatekeeper Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Gate recommendation: approve.

The test correctly follows the provider-owned direct I/O contract introduced by #11221. The targeted scheduler-selection test passes on Linux.

@lance-gatekeeper lance-gatekeeper Bot added the K-approved Latest Gatekeeper recommendation permits acceptance. label Nov 18, 2026
@Xuanwo
Xuanwo merged commit 3f2b154 into main Nov 18, 2026
42 checks passed
@Xuanwo
Xuanwo deleted the xuanwo/fix-lite-scheduler-selection-test branch November 18, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-encoding Encoding, IO, file reader/writer chore K-approved Latest Gatekeeper recommendation permits acceptance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants