Repository navigation
test(io): select the lite scheduler from a provider-built uring store - #11234
Merged
Merged
Conversation
Direct local I/O is a provider declaration since #11221, so a store built with the legacy ObjectStore::new no longer performs io_uring reads. Build the store through the registry like real callers do and assert the uring preference only where the file+uring provider is registered. Fixes the Rust CI failure in test_object_store_selects_scheduler, which failed on Linux, macOS and Windows.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The test correctly follows the provider-owned direct I/O contract introduced by #11221. The targeted scheduler-selection test passes on Linux.
BubbleCal
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust CI is red on main in
lance-io:test_object_store_selects_schedulerfails on Linux, macOS and Windows atassertion failed: uring_store.prefers_lite_scheduler().#11221 made direct local I/O a provider declaration, so the lite scheduler preference now follows what the store will actually do. The test built its uring store with the legacy
ObjectStore::new, which never declares that mapping, and it asserted the preference on platforms where thefile+uringprovider is not registered.Build the store with
ObjectStore::from_uri, the path real callers use, and keep the uring assertions where the scheme exists (Linux). The memory-store preference and the explicitSome(true)override still run on every platform; no runtime behavior changes.Validated on Linux with the
ciprofile:lance-iolibrary tests (700 passed, including the previously failing test) and workspace Clippy.