Repository navigation
Conversation
…name (#11220) First of six draft changes to the Lance storage API, based on c377b70. Local conditional writes stage beside the destination using a fixed-length basename. Construct the sibling from the parsed parent to preserve encoded path components. The existing conditional rename, conflict result, and cleanup behavior are preserved. The local regression writes twice under a non-ASCII parent using a 241-byte basename and checks that the original bytes survive the conflict. The two put-if-absent cases and workspace Clippy also passed with this patch applied to main at 134c2bf. Main already preserves parent encoding for namespace marker staging. **Storage stack (1/6)** · #11220 → #11221 → #11223 → #11225 → #11226 → #11227 The six commits preserve the reviewed tree based on `c377b70b6`. Layer 1 also passed its targeted tests and workspace Clippy on main at `134c2bf95`. Integrating the later layers with newer main changes to S3 markers, cleanup and shallow clones remains separate work.
Depends on #11220. A wrapper installed by the registry or on an existing handle must see local file reads, writes and copies, including external blob reads. Keep native directory maintenance available on built-in file stores. Track the ordinary and external views once at assembly so later wrappers retain their existing relationship to the tracker. Verified 113 lance-io object store tests, including local, file-object-store and Linux io_uring with registry and late wrappers. Workspace Clippy passed for tests and benches. **Storage stack (2/6)** · #11220 → #11221 → #11223 → #11225 → #11226 → #11227
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The migrated paths preserve backend preconditions, streaming behavior, and the separation between request errors and body errors. Strict create-only copy remains separate from staged promotion's same-size retry policy.
Please mark this PR with the breaking-change label: lance_io::object_store::ObjectStore::copy_if_not_exists now has strict create-only semantics and returns object_store::Result<()>, so callers relying on same-size retries or WriteResult must use copy_if_not_exists_or_same_size.
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Depends on #11221.
Move direct GET, ranged GET, HEAD, PUT, LIST, rename and conditional-copy calls behind the Lance handle. Dataset, MemWAL, table and directory-namespace code use the facade. A caller can still distinguish failure to open a response from failure to consume its body.
Expose strict create-only copy separately from the existing staged-file promotion helper that accepts an existing destination with the same size. Namespace marker and manifest fallbacks keep their own conflict handling and cleanup order.
Storage stack (3/6) · #11220 → #11221 → #11223 → #11225 → #11226 → #11227