Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 23 additions & 28 deletions rust/lance-io/src/scheduler.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
// SPDX-License-Identifier: Apache-2.0
// SPDX-FileCopyrightText: Copyright The Lance Authors

Expand Down Expand Up @@ -3212,41 +3212,36 @@
let scheduler = ScanScheduler::new(memory_store.clone(), config);
assert!(!scheduler.uses_lite_scheduler());

// A file+uring:// store should use the lite scheduler when config is None
let uring_store = Arc::new(ObjectStore::new(
Arc::new(InMemory::new()),
Url::parse("file+uring:///tmp").unwrap(),
None,
None,
false,
false,
8,
DEFAULT_DOWNLOAD_RETRY_COUNT,
None,
));
assert!(uring_store.prefers_lite_scheduler());
let config = SchedulerConfig {
io_buffer_size_bytes: 256 * 1024 * 1024,
use_lite_scheduler: None,
};
let scheduler = ScanScheduler::new(uring_store.clone(), config);
assert!(scheduler.uses_lite_scheduler());

// Explicit Some(false) overrides a file+uring:// store's preference
let config = SchedulerConfig {
io_buffer_size_bytes: 256 * 1024 * 1024,
use_lite_scheduler: Some(false),
};
let scheduler = ScanScheduler::new(uring_store, config);
assert!(!scheduler.uses_lite_scheduler());

// Explicit Some(true) overrides a memory:// store's preference
let config = SchedulerConfig {
io_buffer_size_bytes: 256 * 1024 * 1024,
use_lite_scheduler: Some(true),
};
let scheduler = ScanScheduler::new(memory_store, config);
assert!(scheduler.uses_lite_scheduler());

// Only the built-in file provider declares io_uring, and it registers
// its file+uring:// scheme on Linux alone.
#[cfg(target_os = "linux")]
{
// A file+uring:// store should use the lite scheduler when config is None
let (uring_store, _) = ObjectStore::from_uri("file+uring:///tmp").await.unwrap();
assert!(uring_store.prefers_lite_scheduler());
let config = SchedulerConfig {
io_buffer_size_bytes: 256 * 1024 * 1024,
use_lite_scheduler: None,
};
let scheduler = ScanScheduler::new(uring_store.clone(), config);
assert!(scheduler.uses_lite_scheduler());

// Explicit Some(false) overrides a file+uring:// store's preference
let config = SchedulerConfig {
io_buffer_size_bytes: 256 * 1024 * 1024,
use_lite_scheduler: Some(false),
};
let scheduler = ScanScheduler::new(uring_store, config);
assert!(!scheduler.uses_lite_scheduler());
}
}

#[test_log::test(tokio::test(flavor = "multi_thread"))]
Expand Down
Loading