Repository navigation
Tests: pin the default error locations and cross-package code - #6
Merged
Merged
Conversation
Error-message suite (plinth/test/errors): - Run each case in two modes: with preserve-source-locations (goldens in golden/<series>/) and without it (golden/<series>/nolocs/), to pin what a user gets by default. - Fail a case whose error has no located header, also with ACCEPT=1. See Note [Every error has a location] in run-error-tests.sh. - New cases: CrossModule (the error is in an imported module) and InvalidMarker (PLINTH-00006). no-pragmas suite: use functions of another package (plinth-test-dep) that sets no Plinth-specific GHC flag and has no INLINABLE pragma. Bump plutus (ican-group/ghc-plinth-plutus#10): an error without a span is reported at the start of the module. The golden/9.12 files for the new cases and the nolocs mode are not generated yet: the ghc-9.12 branch gets the port separately. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
1 of 3 tasks
macOS has bash 3.2, which rejects the expansion of an empty array under set -u. The nolocs mode has no additional argument, so each of its cases failed with "mode_args[@]: unbound variable". Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardening for the Q4 2026 milestone ("INLINEABLE pragma no longer required across modules. All compilation errors traceable to Haskell source locations. Testsuite for cross-module usability and source-location errors delivered.").
plinth/test/errors: each case now runs in two modes, withpreserve-source-locations(golden/<series>/) and without it (golden/<series>/nolocs/). The second mode pins what a user gets by default.plinth/test/errors: a check that does not depend on the goldens fails a case whose error has noFile.hs:l:c: error:header, also withACCEPT=1.CrossModule(the error is in an imported module and points into it) andInvalidMarker(PLINTH-00006).no-pragmas: also uses functions of another package (plinth/test/no-pragmas-dep) that sets no Plinth-specific GHC flag and has noINLINABLEpragma.<no location info>.Test plan
no-pragmaspasses; 56 of 56 error runs pass.plinthc-test.sh(plutus-tx-plugin,plutus-tx). The local run of these suites did not finish.nolocsgoldens were generated on Linux x86-64 only.golden/9.12for the new cases and thenolocsmode. Theghc-9.12branch gets the port separately.run-error-tests.sh; the second one to merge must combine the mode loops.🤖 Generated with Claude Code