Skip to content

Tests: pin the default error locations and cross-package code (9.12) - #7

Merged
hsyl20 merged 3 commits into
ghc-9.12from
q4-milestone-hardening-9.12
Nov 17, 2026
Merged

hsyl20 merged 3 commits into
ghc-9.12from
q4-milestone-hardening-9.12

Conversation

@hsyl20

@hsyl20 hsyl20 commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

Port of #6 to the ghc-9.12 branch.

Test plan

  • Local, Linux x86-64, with the released plinthc 9.12.170.1: no-pragmas passes (with the other package); 56 of 56 error runs pass. In the nolocs mode, each case has the same location as with GHC 9.6.
  • CI: the released compiler does not contain the plutus change of plinth: report an error without a span at the start of the module ghc-plinth-plutus#10. CI is the first build of GHC 9.12 with it.
  • CI: the compiler test-suites, and the other platforms.

🤖 Generated with Claude Code

hsyl20 and others added 3 commits November 17, 2026 09:50
Error-message suite (plinth/test/errors):
- Run each case in two modes: with preserve-source-locations (goldens in
  golden/<series>/) and without it (golden/<series>/nolocs/), to pin
  what a user gets by default.
- Fail a case whose error has no located header, also with ACCEPT=1.
  See Note [Every error has a location] in run-error-tests.sh.
- New cases: CrossModule (the error is in an imported module) and
  InvalidMarker (PLINTH-00006).

no-pragmas suite: use functions of another package (plinth-test-dep)
that sets no Plinth-specific GHC flag and has no INLINABLE pragma.

Bump plutus (ican-group/ghc-plinth-plutus#10): an error without a span
is reported at the start of the module.

The golden/9.12 files for the new cases and the nolocs mode are not
generated yet: the ghc-9.12 branch gets the port separately.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…ocs mode

Generated with plinthc 9.12.170.1. The existing golden/9.12 files do not
change.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
macOS has bash 3.2, which rejects the expansion of an empty array under
set -u. The nolocs mode has no additional argument, so each of its
cases failed with "mode_args[@]: unbound variable".

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@hsyl20
hsyl20 merged commit f141ca3 into ghc-9.12 Nov 17, 2026
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant