Skip to content

perf(core): slice known prefixes when formatting file names - #8885

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/perf-diagnostic-path-prefix
Nov 16, 2026
Merged

chenjiahan merged 1 commit into
mainfrom
chenjiahan/perf-diagnostic-path-prefix

Conversation

@chenjiahan

@chenjiahan chenjiahan commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Motivation

Avoid searching for prefixes that have already been matched while formatting diagnostic paths.

Changes

Slice known project-root and data-URI prefixes instead of replacing them.

Local helper benchmark (project-relative diagnostic formatting, including color formatting; Node 24.19.0, Apple M5 Max; medians from 3 processes × 11 warmed A/B rounds).

Before After Speedup
316.4 ns/call 297.0 ns/call 6.5% faster

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T11:33:41.233705Z 21ea355 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chenjiahan
chenjiahan merged commit 173cae3 into main Nov 16, 2026
8 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/perf-diagnostic-path-prefix branch November 16, 2026 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant