Skip to content

perf(core): simplify formatting the first changed file - #8882

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/perf-build-log-file-list
Nov 16, 2026
Merged

chenjiahan merged 1 commit into
mainfrom
chenjiahan/perf-build-log-file-list

Conversation

@chenjiahan

@chenjiahan chenjiahan commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Motivation

Avoid temporary arrays when formatting the first changed file in build logs.

Changes

Format the first matching file directly, preserving the empty-list fallback and remaining-file count.

Local helper benchmark (a single changed file; Node 24.19.0, Apple M5 Max; medians from 3 processes × 11 warmed A/B rounds).

Before After Speedup
275.3 ns/call 246.0 ns/call 11.9% faster

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T11:33:43.913598Z ac3e5f8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chenjiahan
chenjiahan merged commit 6b613ae into main Nov 16, 2026
8 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/perf-build-log-file-list branch November 16, 2026 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant