Skip to content

perf(core): avoid splitting loader chains in diagnostics - #8879

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/perf-loader-chain-prefix
Nov 16, 2026
Merged

chenjiahan merged 1 commit into
mainfrom
chenjiahan/perf-loader-chain-prefix

Conversation

@chenjiahan

@chenjiahan chenjiahan commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Motivation

Avoid allocating split arrays when removing loader-chain suffixes from diagnostics.

Changes

Find the first loader-chain delimiter with indexOf() and slice the prefix, preserving verbose output.

Local helper benchmark (module identifiers containing loader chains; Node 24.19.0, Apple M5 Max; medians from 3 processes × 11 warmed A/B rounds).

Before After Speedup
68.1 ns/call 17.5 ns/call 288.3% faster

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T11:33:32.680286Z 331a5bb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chenjiahan
chenjiahan merged commit 3957c2b into main Nov 16, 2026
8 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/perf-loader-chain-prefix branch November 16, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant