Repository navigation
Conversation
…ton typo - Ensure sidebar navigation items remain visible on mobile/small viewports by removing the inappropriate 'hidden md:flex md:col-span-3' class from DashboardNav in Sidebar. - Remove redundant and conflicting 'bg-neutral-100' class from Sidebar aside to preserve theme-aware 'bg-card' styling. - Correct invalid 'grid-col-1' Tailwind CSS class typo to 'grid-cols-1' and align layout with 'items-start' in DashboardSkeleton. - Remove misleading 'cursor-pointer' affordance from non-interactive DashboardCard. Signed-off-by: Norway-02 <anshulkhetade02@gmail.com>
|
@Norway-02: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
cc @de6p @JesseStutler @kevin-wangzefeng for review when you have a moment. Thanks! |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR resolves two UI issues impacting dashboard responsiveness and layout consistency:
Mobile Sidebar Navigation Visibility:
apps/web/src/components/(dashboard)/layout/sidebar.tsx,DashboardNavwas rendered withclassName="hidden md:flex md:col-span-3". Becausehiddenapplies to viewports below themdbreakpoint (<768px), navigation links (Jobs, Queues, Pods, PodGroups) were completely hidden on mobile and narrow browser viewports, leaving users with an empty sidebar.hidden md:flex md:col-span-3and passedw-fullso navigation links remain accessible across all screen sizes.bg-neutral-100class from the<aside>element so the theme-awarebg-cardclass is respected.Dashboard Skeleton Grid Typo:
apps/web/src/components/(dashboard)/dashboard-utils.tsx,DashboardSkeletonusedgrid-col-1which is an invalid Tailwind CSS class (the valid utility isgrid-cols-1, as used in the loaded section). This caused layout jumping on mobile viewports while loading chart metrics.grid-col-1togrid-cols-1and aligned withitems-start.cursor-pointeraffordance from the non-interactiveDashboardCard.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
lint,check-types,i18n:validate, and productionbuild.Does this PR introduce a user-facing change?