Skip to content

fix(web): resolve mobile sidebar navigation visibility and grid skeleton typo - #399

Open
Norway-02 wants to merge 1 commit into
volcano-sh:mainfrom
Norway-02:fix/web-sidebar-mobile-nav-and-grid-skeleton-typo
Open

Norway-02 wants to merge 1 commit into
volcano-sh:mainfrom
Norway-02:fix/web-sidebar-mobile-nav-and-grid-skeleton-typo

Conversation

@Norway-02

Copy link
Copy Markdown

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR resolves two UI issues impacting dashboard responsiveness and layout consistency:

  1. Mobile Sidebar Navigation Visibility:

    • In apps/web/src/components/(dashboard)/layout/sidebar.tsx, DashboardNav was rendered with className="hidden md:flex md:col-span-3". Because hidden applies to viewports below the md breakpoint (<768px), navigation links (Jobs, Queues, Pods, PodGroups) were completely hidden on mobile and narrow browser viewports, leaving users with an empty sidebar.
    • Removed hidden md:flex md:col-span-3 and passed w-full so navigation links remain accessible across all screen sizes.
    • Removed the redundant and conflicting bg-neutral-100 class from the <aside> element so the theme-aware bg-card class is respected.
  2. Dashboard Skeleton Grid Typo:

    • In apps/web/src/components/(dashboard)/dashboard-utils.tsx, DashboardSkeleton used grid-col-1 which is an invalid Tailwind CSS class (the valid utility is grid-cols-1, as used in the loaded section). This caused layout jumping on mobile viewports while loading chart metrics.
    • Corrected grid-col-1 to grid-cols-1 and aligned with items-start.
    • Removed misleading cursor-pointer affordance from the non-interactive DashboardCard.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

  • Zero breaking changes to public APIs.
  • Fully tested across lint, check-types, i18n:validate, and production build.

Does this PR introduce a user-facing change?

Fix hidden navigation links on mobile sidebar viewports and correct grid-cols class typo in dashboard skeleton loader.

…ton typo

- Ensure sidebar navigation items remain visible on mobile/small viewports by removing the inappropriate 'hidden md:flex md:col-span-3' class from DashboardNav in Sidebar.
- Remove redundant and conflicting 'bg-neutral-100' class from Sidebar aside to preserve theme-aware 'bg-card' styling.
- Correct invalid 'grid-col-1' Tailwind CSS class typo to 'grid-cols-1' and align layout with 'items-start' in DashboardSkeleton.
- Remove misleading 'cursor-pointer' affordance from non-interactive DashboardCard.

Signed-off-by: Norway-02 <anshulkhetade02@gmail.com>
@volcano-sh-bot

Copy link
Copy Markdown
Contributor

@Norway-02: The label(s) kind/bug cannot be applied, because the repository doesn't have them.

Details

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR resolves two UI issues impacting dashboard responsiveness and layout consistency:

  1. Mobile Sidebar Navigation Visibility:
  • In apps/web/src/components/(dashboard)/layout/sidebar.tsx, DashboardNav was rendered with className="hidden md:flex md:col-span-3". Because hidden applies to viewports below the md breakpoint (<768px), navigation links (Jobs, Queues, Pods, PodGroups) were completely hidden on mobile and narrow browser viewports, leaving users with an empty sidebar.
  • Removed hidden md:flex md:col-span-3 and passed w-full so navigation links remain accessible across all screen sizes.
  • Removed the redundant and conflicting bg-neutral-100 class from the <aside> element so the theme-aware bg-card class is respected.
  1. Dashboard Skeleton Grid Typo:
  • In apps/web/src/components/(dashboard)/dashboard-utils.tsx, DashboardSkeleton used grid-col-1 which is an invalid Tailwind CSS class (the valid utility is grid-cols-1, as used in the loaded section). This caused layout jumping on mobile viewports while loading chart metrics.
  • Corrected grid-col-1 to grid-cols-1 and aligned with items-start.
  • Removed misleading cursor-pointer affordance from the non-interactive DashboardCard.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

  • Zero breaking changes to public APIs.
  • Fully tested across lint, check-types, i18n:validate, and production build.

Does this PR introduce a user-facing change?

Fix hidden navigation links on mobile sidebar viewports and correct grid-cols class typo in dashboard skeleton loader.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@volcano-sh-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kevin-wangzefeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Norway-02

Copy link
Copy Markdown
Author

cc @de6p @JesseStutler @kevin-wangzefeng for review when you have a moment. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants