Repository navigation
Conversation
Use next-intl translation keys instead of hardcoded English strings across queue and pod management dialogs: - In QueueEditDialog: localize dialog title and description, Form and YAML tab buttons, Cancel and Reset actions, and YAML parse error fallback. - In PodEditDialog & CreatePodDialog: localize the Reset button using the shared common action translation. Signed-off-by: Norway-02 <anshulkhetade02@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
|
Hi @de6p @JesseStutler @kevin-wangzefeng, could you please review this PR when you have a moment? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR localizes hardcoded English strings in queue and pod management dialogs using existing
next-intltranslation keys:QueueEditDialog(apps/web/src/components/(dashboard)/queues/queue-edit-dialog.tsx):{t("edit.title", { name: queueName })}{t("edit.description")}{t("create.formTab")}and{t("create.yamlTab")}{tc("actions.cancel")}and{tc("actions.reset")}t("create.parseFormFailed")PodEditDialog(apps/web/src/components/(dashboard)/pods/pod-edit-dialog.tsx):{tc("actions.reset")}CreatePodDialog(apps/web/src/components/(dashboard)/pods/pod-create-dialog.tsx):{tc("actions.reset")}All matching translation keys are already defined in
messages/en/andmessages/zh-CN/, ensuring full localization completeness without any dictionary schema drift.Verification:
npm run i18n:validate --workspace=web: Passed (all locale message keys in sync)npm run check-types: Passed (0 errors)npm run lint: Passed (0 errors)npm run build: Passed (production build succeeded)