Repository navigation
Feat/kthena dashboard - #393
Open
kashmeertl wants to merge 23 commits into
Open
kashmeertl wants to merge 23 commits into
kashmeertl wants to merge 23 commits into
Conversation
The dashboard had no test runner; Kthena list/get logic needs one before it lands. Signed-off-by: Meer <kashmeertl@gmail.com>
Operators still need kubectl for inference CRDs; this adds a tested list/get path that degrades when CRDs are missing and grants the install ClusterRole access to the four serving APIs. Signed-off-by: Meer <kashmeertl@gmail.com>
List views need a stable badge from Kthena conditions, and create/update/delete share one factory so later CRDs do not copy CustomObjectsApi glue. Signed-off-by: Meer <kashmeertl@gmail.com>
Read-only list/get is not enough for YAML round-trip; mutations reuse the factory and keep operator-facing Kubernetes errors. Signed-off-by: Meer <kashmeertl@gmail.com>
The page and sidebar need locale keys before UI lands so en and zh-CN stay in lockstep. Signed-off-by: Meer <kashmeertl@gmail.com>
Operators should find inference workloads separately from Jobs and Queues, with room for later Kthena pages. Signed-off-by: Meer <kashmeertl@gmail.com>
The table needs the same Jobs-style filters plus replica and scheduler fields so operators can scan serving health. Signed-off-by: Meer <kashmeertl@gmail.com>
de6p
suggested changes
Oct 5, 2026
de6p
left a comment
Contributor
There was a problem hiding this comment.
please add the description to the PR
Phase 1 stays on Jobs-style YAML, not form builders, so operators can paste a one-role ModelServing and update it in place. Signed-off-by: Meer <kashmeertl@gmail.com>
This closes Phase 1 YAML round-trip: list, inspect, delete, and a clear message when Kthena CRDs are not installed. Signed-off-by: Meer <kashmeertl@gmail.com>
Contributor
Author
|
added |
The list and detail views need the rolling-update count, not only available replicas. Signed-off-by: Meer <kashmeertl@gmail.com>
Operators should see why a serving is Progressing without opening YAML. Signed-off-by: Meer <kashmeertl@gmail.com>
Related links need a tested mapping from labels, ownerRefs, and the queue annotation. Signed-off-by: Meer <kashmeertl@gmail.com>
The detail dialog cannot jump to Pods until the API can list by modelserving.volcano.sh/name. Signed-off-by: Meer <kashmeertl@gmail.com>
ModelBooster, ModelServer, and ModelRoute need the same owner, selector, and target mapping so detail links stay consistent. Signed-off-by: Meer <kashmeertl@gmail.com>
List badges and YAML create need kind-specific checks and status fields before the remaining pages land. Signed-off-by: Meer <kashmeertl@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The remaining CRDs reuse the shared factory so YAML list, get, create, update, delete, and getRelated do not copy CustomObjectsApi glue. Signed-off-by: Meer <kashmeertl@gmail.com>
Three more CRDs should share Jobs-style YAML dialogs and related chips instead of copying another management page. Signed-off-by: Meer <kashmeertl@gmail.com>
Operators debugging a serving need to jump onto pages the dashboard already has, including via ns and name query params. Signed-off-by: Meer <kashmeertl@gmail.com>
The sidebar and en/zh-CN keys need to land before the ModelBooster, ModelServer, and ModelRoute pages. Signed-off-by: Meer <kashmeertl@gmail.com>
Most operators deploy through ModelBooster, so the dashboard needs the same list, YAML round-trip, and child links as ModelServing. Signed-off-by: Meer <kashmeertl@gmail.com>
Routing and serving debug needs the inference engine, port, and workloadSelector pods in the same Jobs-style UI. Signed-off-by: Meer <kashmeertl@gmail.com>
Operators should inspect target ModelServers and parent Gateway refs without kubectl. Signed-off-by: Meer <kashmeertl@gmail.com>
Install and related-link behavior belongs next to the README so operators know Kthena CRDs are optional. Signed-off-by: Meer <kashmeertl@gmail.com>
Contributor
Author
|
@de6p @JesseStutler please review . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds Phase 1 Kthena support so operators can manage
ModelServingfrom the dashboard the same way they manage Jobs: list, inspect YAML, create, edit, and delete.Without Kthena CRDs installed, the page stays up and shows that the CRDs are missing. Jobs, Queues, Pods, and PodGroups are unchanged.
Why
Kthena inference workloads (
workload.serving.volcano.sh/networking.serving.volcano.sh) were kubectl-only. This is the first vertical slice: one CRD, YAML round-trip, no form builders.What's included
@volcano/trpcand a shared Kthena CustomObjects factory (list/get/create/replace/delete, missing-CRD 404, replace payload merge)Available>UpdateInProgress>Progressing>Unknown)/model-servingspage: table, YAML create/edit dialogs, detail dialog, delete confirmOut of scope