Repository navigation
fix: correct status badge colors and complete-rate calculation - #323
Merged
volcano-sh-bot merged 1 commit intoOct 28, 2026
Merged
Conversation
Contributor
|
Welcome @kashmeertl! It looks like this is your first PR to volcano-sh/dashboard 🎉 |
Contributor
|
please fix |
kashmeertl
force-pushed
the
fix/status-badge-colors
branch
from
October 27, 2026 03:34
2fc973c to
3835ea2
Compare
Normalize job/pod status colors via a shared helper so PascalCase Volcano phases map correctly, and count only Completed jobs in complete rate. Signed-off-by: Meer <kashmeertl@gmail.com>
kashmeertl
force-pushed
the
fix/status-badge-colors
branch
from
October 27, 2026 14:40
3835ea2 to
4e7a73d
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: de6p The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Job status badges were basically all red. Volcano returns phases like
Running/Completed, but the UI was matching lowercase strings, so almost everything hit the error color.Also cleaned up a couple related bugs while in there:
getAllJobswas overwriting the real phase with"Running"because of a bad ternary/||comboPulled the color mapping into
status-colors.tsso jobs, pods, podgroups, and the pie chart stay in sync.