Skip to content

fix: correct status badge colors and complete-rate calculation - #323

Merged
volcano-sh-bot merged 1 commit into
volcano-sh:mainfrom
kashmeertl:fix/status-badge-colors
Oct 28, 2026
Merged

volcano-sh-bot merged 1 commit into
volcano-sh:mainfrom
kashmeertl:fix/status-badge-colors

Conversation

@kashmeertl

Copy link
Copy Markdown
Contributor

What

Job status badges were basically all red. Volcano returns phases like Running / Completed, but the UI was matching lowercase strings, so almost everything hit the error color.

Also cleaned up a couple related bugs while in there:

  • getAllJobs was overwriting the real phase with "Running" because of a bad ternary/|| combo
  • Complete Rate was treating anything not-active as complete (including Failed)

Pulled the color mapping into status-colors.ts so jobs, pods, podgroups, and the pie chart stay in sync.

@volcano-sh-bot

Copy link
Copy Markdown
Contributor

Welcome @kashmeertl! It looks like this is your first PR to volcano-sh/dashboard 🎉

@de6p

de6p commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

please fix do-not-merge/contains-merge-commits

Normalize job/pod status colors via a shared helper so PascalCase Volcano phases map correctly, and count only Completed jobs in complete rate.

Signed-off-by: Meer <kashmeertl@gmail.com>
@kashmeertl
kashmeertl force-pushed the fix/status-badge-colors branch from 3835ea2 to 4e7a73d Compare October 27, 2026 14:40

@de6p de6p left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
/lgtm

@volcano-sh-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: de6p

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot
volcano-sh-bot merged commit c1b9aa0 into volcano-sh:main Oct 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants