Repository navigation
Conversation
The Bool embedding's function lemmas stop at five arguments. Past that, a function keeps its Bool type while its applications are embedded as propositions, and the goal fails to elaborate or reaches cvc5 malformed. Add the sixth lemmas of both families, copies of the fifth, and test both families at five and six arguments. Adding embedding lemmas changes the order in which counter-examples list their assignments, so the Assoc and Comm expected files are regenerated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cherry-pick of ufmg-smite#277 onto
v4.35.0-veil-no-mathlib, the branch Veil pins, so that Veil can take it before this branch next moves to a newer upstream. Once Veil's manifest points here, it fixes verse-lab/veil#177: withveil.smt.trust false, a relation with six arguments made every preservation check of a module fail, because the Bool embedding's function lemmas stopped at five arguments.The commit adds
forall_bool_out_as_prop₆andforall_bool_in_as_prop₆, copies of the fifth lemmas, withTest/Bool/Arity6.lean.Test/Bool/Assoc.expectedandTest/Bool/Comm.expectedlist the same counter-examples in another order: the order changes with the set of embedding lemmas.Tested on this branch with Lean 4.35.0:
lake build Smt Smt.Ratandlake run test, all 107 tests pass (106 before the change). On the branch's tip the two six-argument cases ofTest/Bool/Arity6.leanfail with "type expected" and cvc5's "Expected SMT-LIBv2 sort constructor".This branch's CI workflow will fail on this PR, as it does on the branch's tip (293dab6, 2026-11-05): it runs
lake build Smt Smt.Rat Smt.Real, andSmt.Realimports mathlib, which this branch does not require. The PR leaves the workflow as it is.