Repository navigation
Fix release signing during fork PR validation - #378
Merged
Merged
Conversation
Skip release signing when no signing secrets are available, and fail early if only part of the signing configuration is supplied. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: deee509c-1c42-4c17-be77-3db41c14502a
valterc
enabled auto-merge (squash)
October 12, 2026 12:17
valterc
disabled auto-merge
October 12, 2026 12:17
valterc
enabled auto-merge (squash)
October 12, 2026 12:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork pull requests do not receive repository secrets, but the validation workflow still created an empty keystore and configured release signing. This caused
:app:packageReleaseto fail withTag number over 30 is not supported.Only configure release signing when the signing secrets are available. When all three secrets are absent, log a notice and build an unsigned release APK; when only some are supplied, fail early with a clear error. Signed validation builds, JDK 25, and the tagged-release workflow remain unchanged.