Repository navigation
feat: support resolved config paths in extends - #1317
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defineConfigcurrently treats every string inextendsas a plugin configuration name, so a resolved shared-config path fails to load. It now acceptsextends: require.resolve('@example/lint-preset'), or an array mixing resolved paths, configuration objects and plugin configuration names.Shared modules can export objects or arrays using CommonJS, ESM, JSON or TypeScript. Nested path inheritance preserves file scopes, global ignores and override order; circular paths and invalid exports produce errors. Exported factories are not invoked automatically. Relative paths must first be resolved by the calling configuration.
Validation: 209 configuration, discovery, flat-config and legacy-compatibility tests passed; configuration type checks passed. Coverage includes both ESM and CommonJS helpers and a TypeScript CLI configuration inheriting a resolved package path.