Skip to content

feat: support resolved config paths in extends - #1317

Merged
fireairforce merged 1 commit into
mainfrom
zoomdong/config-path-extends
Oct 29, 2026
Merged

fireairforce merged 1 commit into
mainfrom
zoomdong/config-path-extends

Conversation

@fireairforce

Copy link
Copy Markdown
Member

defineConfig currently treats every string in extends as a plugin configuration name, so a resolved shared-config path fails to load. It now accepts extends: require.resolve('@example/lint-preset'), or an array mixing resolved paths, configuration objects and plugin configuration names.

Shared modules can export objects or arrays using CommonJS, ESM, JSON or TypeScript. Nested path inheritance preserves file scopes, global ignores and override order; circular paths and invalid exports produce errors. Exported factories are not invoked automatically. Relative paths must first be resolved by the calling configuration.

Validation: 209 configuration, discovery, flat-config and legacy-compatibility tests passed; configuration type checks passed. Coverage includes both ESM and CommonJS helpers and a TypeScript CLI configuration inheriting a resolved package path.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T07:52:05.348558Z 1e18a0b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codspeed

codspeed Bot commented Oct 29, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 5 untouched benchmarks


Comparing zoomdong/config-path-extends (1e18a0b) with main (cc9c4e1)

Open in CodSpeed

@fireairforce
fireairforce merged commit 0905f79 into main Oct 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant