Skip to content

fix: make dependency rule framework mappings configurable - #1315

Merged
fireairforce merged 2 commits into
mainfrom
zoomdong/smallfish-internal-rule-compat
Oct 28, 2026
Merged

fireairforce merged 2 commits into
mainfrom
zoomdong/smallfish-internal-rule-compat

Conversation

@fireairforce

@fireairforce fireairforce commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Dependency rules read framework JS/TS config aliases and accept consumer-provided package mappings. externalAlias and externalDependencies describe runtime imports; externalPackages maps packages to stdlib paths and major versions. Public fixtures use generic example packages.

Adding owned mapping buffers exposed per-file copies of the full configuration through semantic passes. Internal passes now borrow the configuration, copying only when file-dependent defaults need adjustment. Public APIs and buffer capacities remain unchanged.

Validation: Zig 0.17.0 full suite passed (2333 tests and 91 rule snapshots); native release build passed. Regression cases cover mapping validation, configuration reuse, Jest detection, declaration-file namespaces and both IO paths for operand checking.

Local native comparison, same 1000-file corpus / 30 statement blocks, release-fast builds, 5 warmups and 21 interleaved samples per binary (median):

Rules Main baseline Before copy fix Current head
Shared rules 50.00 ms 53.41 ms 32.24 ms
Basic-only control 26.87 ms 26.93 ms 24.12 ms
Semantic-only control 45.61 ms 49.60 ms 28.88 ms

Current-head Node.js 20/24 and WebAssembly CI passed. CodSpeed also passed: the shared native benchmark improved from 592.1 ms to 269.4 ms (2.2x efficiency), with three improved benchmarks and two unchanged.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T07:16:24.038701Z 0c61f8d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@fireairforce fireairforce changed the title fix: recognize Smallfish projects in dependency rules fix: make dependency rule framework mappings configurable Oct 28, 2026
@fireairforce
fireairforce force-pushed the zoomdong/smallfish-internal-rule-compat branch from 0c61f8d to 5081826 Compare October 28, 2026 07:30
@codspeed

codspeed Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Merging this PR will improve performance by 70.82%

⚡ 3 improved benchmarks
✅ 2 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ utoo-lint/fixtures/codspeed 592.1 ms 269.4 ms ×2.2
⚡ npm-wrapper/umi-severity-config/1000-files 1,457.8 ms 774.5 ms +88.24%
⚡ npm-wrapper/native-flat-config/1000-files 1.8 s 1.5 s +20.47%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing zoomdong/smallfish-internal-rule-compat (ae81e95) with main (3c08b00)

Open in CodSpeed

@fireairforce
fireairforce merged commit cc9c4e1 into main Oct 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant