Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #895.
RFC 6120 § 6.3.10 requires clients to support the less efficient SASL mode, in which a server doesn't send additional data with
<success>. For SCRAM that data is the server-final message (v=<signature>), which such a server sends as a second<challenge>. The client answers with an empty<response/>and the server then sends an empty<success/>.Strophe parsed that second challenge as a server-first message and aborted with
SCRAM_BAD_CHALLENGE.Now:
<response/>. If it's wrong, missing or ane=server error, Strophe aborts withSCRAM_BAD_SERVER_SIGNATURE.<success/>is accepted once the signature was verified that way. A<success>that carries data must still carry the right signature.SCRAM_BAD_CHALLENGE, as does av=challenge before the first one was answered.Prosody and ejabberd send
v=in<success>, so they weren't affected.