Repository navigation
fix(visualiser): remove external Google Fonts @import for offline environments - #3476
Open
reginaldalfret wants to merge 1 commit into
Open
reginaldalfret wants to merge 1 commit into
reginaldalfret wants to merge 1 commit into
Conversation
AdminLTE.min.css included an @import url(https://fonts.googleapis.com/...) stylesheet dependency. In isolated/offline environments without direct internet access or in firewalled internal enterprise clusters, the browser hangs attempting to load the Google Fonts stylesheet before timing out, causing severe delays loading the visualizer web interface. AdminLTE's body rule already specifies a resilient system font fallback stack ('Source Sans Pro', 'Helvetica Neue', Helvetica, Arial, sans-serif). Removing this external network request allows the visualizer to load immediately in air-gapped and offline setups. Fixes spotify#3347 Signed-off-by: reginaldalfret <reginaldalfret@gmail.com>
Manishram-ai
approved these changes
Nov 1, 2026
Manishram-ai
left a comment
There was a problem hiding this comment.
Looks good. Every place in this file that uses Source Sans Pro already falls back to a system font, so removing the import doesn't break anything. The page will just use the system font when Source Sans Pro isn't installed, and I think that's fine if it means the page doesn't hang offline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
\luigi/static/visualiser/lib/AdminLTE/css/AdminLTE.min.css\ started with an @import url(https://fonts.googleapis.com/...);\ directive. In offline, firewalled, or air-gapped environments without external internet connectivity, browser rendering of the Luigi task visualiser interface stalls for a long period while waiting for the remote font request to time out.
Solution
Remove the remote @import url(https://fonts.googleapis.com/...)\ stylesheet from AdminLTE.min.css. AdminLTE already specifies a fallback typography stack ('Source Sans Pro', 'Helvetica Neue', Helvetica, Arial, sans-serif), allowing the page to render instantly without external network dependencies.
Fixes #3347.