Skip to content

fix: use virtualHost and virtualPort in dubbo protocol config - #1580

Open
Code-by-ing wants to merge 2 commits into
sofastack:masterfrom
Code-by-ing:fix/dubbo-virtural-host
Open

Code-by-ing wants to merge 2 commits into
sofastack:masterfrom
Code-by-ing:fix/dubbo-virtural-host

Conversation

@Code-by-ing

Copy link
Copy Markdown

Motivation:

When using Dubbo protocol in NAT/container/LB/port-mapping environments, virtualHost and virtualPort from ServerConfig are ignored in DubboProviderBootstrap.copyServerFields(). This causes incorrect addresses to be registered to the registry. The Bolt protocol already handles this correctly, but Dubbo protocol does not.

Modification:

  • Modified DubboProviderBootstrap.copyServerFields() to prioritize virtualHost/virtualPort when configured, with fallback to host/port
  • Updated buildUrls() to use the same resolved host/port for consistency
  • Added unit tests in DubboProviderBootstrapTest.java covering virtual host/port combinations

Result:

Fixes #1119

@sofastack-cla sofastack-cla Bot added bug Something isn't working cla:yes CLA is ok First-time contributor First-time contributor size/L labels Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cla:yes CLA is ok First-time contributor First-time contributor size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dubbo ProtocolConfig doesn't use server's virtualHost at all

1 participant