Repository navigation
Fix RUSTSEC-2026-0548 (zip) and RUSTSEC-2026-0543 (chrono) - #3769
Merged
Merged
Conversation
zip: bump 9.0.3 -> 9.0.5 and require >= 9.0.5. The advisory is in ZipStreamReader, which fresh-update does not use (it opens downloads with ZipArchive::new), but the self-update path now also calls validate_header_consistency() so a zip whose local headers disagree with its central directory is refused instead of read by one of the two names. Checked against the current Windows CLI and GUI release zips. chrono: replace fresh-editor's and fresh-editor-core's own uses with jiff (log timestamps, event-log stamps, status-bar clock, file-open dates, telemetry stamp date, TimeSource). Output is unchanged; new tests pin the formats. chrono stays in the tree through trash on Linux/BSD, which needs it to write DeletionDate into .trashinfo files, so deny.toml gets an ignore entry with that reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LCVsbiyn1hmXVCPouBWKiz
sinelaw
enabled auto-merge (squash)
November 17, 2026 12:29
chrono stays in the tree through trash regardless, so revert the jiff migration (and its Debian Build-Depends change) and keep chrono for now. deny.toml's ignore reason now says it is used directly and via trash. Cargo.lock goes back to master's plus only the zip 9.0.3 -> 9.0.5 bump. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LCVsbiyn1hmXVCPouBWKiz
Owner
Author
|
CI notes. Neither failure below comes from this PR, which touches only
Generated by Claude Code |
A credit can hold its own ';' ('(#3293, requested by @A; #3581 by @b)').
shorten() cut the clause at the first ';' and then stripped credits, so the
credit lost its ')' and was left in the line, failing
the_real_changelog_parses on the 0.5.9 CHANGELOG. Strip credits first.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LCVsbiyn1hmXVCPouBWKiz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
advisoriesjob (cargo deny --all-features check advisories) fails on every PR because of two new RustSec advisories. This fixes both. It also fixes a test that fails onmaster, so CI can go green.RUSTSEC-2026-0548:
zip9.0.3zipgoes from 9.0.3 to 9.0.5, andfresh-updatenow requires at least 9.0.5. That bump is the only change toCargo.lock.ZipStreamReader.fresh-update/src/archive.rsopens downloads withZipArchive::new, so it was not affected.ZipArchive::validate_header_consistency(), which was added in the fixed release. A zip whose local headers disagree with its central directory, overlap or repeat a name is refused rather than read by one of its two names.zip5.x, so its build already skipped this optional dependency. Nothing changes for the Debian package.RUSTSEC-2026-0543:
chronois unmaintained, not vulnerablechronostays for now.trashalso uses it on Linux/BSD to writeDeletionDatein.trashinfofiles, and notrashrelease drops it, so switching fresh's own code alone wouldn't remove it from the tree.deny.tomlgets an ignore entry with that reason.the_real_changelog_parses(failing onmaster);: "(ctrl + p , path tab should only complete longest common prefix #3293, requested by @…; Palette file mode: Tab completes the longest common prefix #3581 by @…)".release_notes::parse::shortencut a continuing clause at the first;before stripping credits. The credit lost its closing)and stayed in the line.Not fixed here:
Debian package (unstable, amd64)Debian unstable's own
librust-notify-dev8.2.0-2+b1 depends onlibrust-flume-0.11, but unstable now has onlyflume0.12.0. The build dependencies can't be installed until Debian rebuildsnotify.I agree my contributions are licensed under GPL-3.0-or-later and may be relicensed in the future at the maintainer's discretion (see CONTRIBUTING.md).
🤖 Generated with Claude Code
https://claude.ai/code/session_01LCVsbiyn1hmXVCPouBWKiz