Skip to content

Fix RUSTSEC-2026-0548 (zip) and RUSTSEC-2026-0543 (chrono) - #3769

Merged
sinelaw merged 3 commits into
masterfrom
fix/rustsec-zip-chrono
Nov 17, 2026
Merged

sinelaw merged 3 commits into
masterfrom
fix/rustsec-zip-chrono

Conversation

@sinelaw

@sinelaw sinelaw commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

The advisories job (cargo deny --all-features check advisories) fails on every PR because of two new RustSec advisories. This fixes both. It also fixes a test that fails on master, so CI can go green.

RUSTSEC-2026-0548: zip 9.0.3

  • zip goes from 9.0.3 to 9.0.5, and fresh-update now requires at least 9.0.5. That bump is the only change to Cargo.lock.
  • The advisory is in ZipStreamReader. fresh-update/src/archive.rs opens downloads with ZipArchive::new, so it was not affected.
  • Self-update now also calls ZipArchive::validate_header_consistency(), which was added in the fixed release. A zip whose local headers disagree with its central directory, overlap or repeat a name is refused rather than read by one of its two names.
  • A new test patches a local-header name and checks the zip is refused. The current Windows CLI and GUI release zips still extract with the check on.
  • Debian ships only zip 5.x, so its build already skipped this optional dependency. Nothing changes for the Debian package.

RUSTSEC-2026-0543: chrono is unmaintained, not vulnerable

  • chrono stays for now. trash also uses it on Linux/BSD to write DeletionDate in .trashinfo files, and no trash release drops it, so switching fresh's own code alone wouldn't remove it from the tree.
  • deny.toml gets an ignore entry with that reason.

the_real_changelog_parses (failing on master)

Not fixed here: Debian package (unstable, amd64)

  • Debian unstable's own librust-notify-dev 8.2.0-2+b1 depends on librust-flume-0.11, but unstable now has only flume 0.12.0. The build dependencies can't be installed until Debian rebuilds notify.

  • I agree my contributions are licensed under GPL-3.0-or-later and may be relicensed in the future at the maintainer's discretion (see CONTRIBUTING.md).

🤖 Generated with Claude Code

https://claude.ai/code/session_01LCVsbiyn1hmXVCPouBWKiz

zip: bump 9.0.3 -> 9.0.5 and require >= 9.0.5. The advisory is in
ZipStreamReader, which fresh-update does not use (it opens downloads with
ZipArchive::new), but the self-update path now also calls
validate_header_consistency() so a zip whose local headers disagree with
its central directory is refused instead of read by one of the two names.
Checked against the current Windows CLI and GUI release zips.

chrono: replace fresh-editor's and fresh-editor-core's own uses with jiff
(log timestamps, event-log stamps, status-bar clock, file-open dates,
telemetry stamp date, TimeSource). Output is unchanged; new tests pin the
formats. chrono stays in the tree through trash on Linux/BSD, which needs
it to write DeletionDate into .trashinfo files, so deny.toml gets an ignore
entry with that reason.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LCVsbiyn1hmXVCPouBWKiz
@sinelaw
sinelaw enabled auto-merge (squash) November 17, 2026 12:29
chrono stays in the tree through trash regardless, so revert the jiff
migration (and its Debian Build-Depends change) and keep chrono for now.
deny.toml's ignore reason now says it is used directly and via trash.
Cargo.lock goes back to master's plus only the zip 9.0.3 -> 9.0.5 bump.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LCVsbiyn1hmXVCPouBWKiz

sinelaw commented Nov 17, 2026

Copy link
Copy Markdown
Owner Author

CI notes. Neither failure below comes from this PR, which touches only fresh-update, the zip entry in Cargo.lock, and deny.toml.

  • Debian package (unstable, amd64): the build dependencies can't be installed. Debian unstable's librust-notify-dev (8.2.0-2+b1) depends on librust-flume-0.11+default-dev, but unstable now ships librust-flume-dev 0.12.0-1, so no 0.11 package exists. This is an archive transition on Debian's side and fails before anything from this branch is built. It should clear when Debian rebuilds notify against flume 0.12.
  • test … (2/2): release_notes::parse::tests::the_real_changelog_parses fails the same way on master (d9c76f7). The latest CHANGELOG.md entry "Tab completes the longest common prefix … (ctrl + p , path tab should only complete longest common prefix #3293, requested by …; Palette file mode: Tab completes the longest common prefix #3581 by …)" keeps its credit after parsing. That needs its own fix in the parser or the changelog.

Generated by Claude Code

A credit can hold its own ';' ('(#3293, requested by @A; #3581 by @b)').
shorten() cut the clause at the first ';' and then stripped credits, so the
credit lost its ')' and was left in the line, failing
the_real_changelog_parses on the 0.5.9 CHANGELOG. Strip credits first.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LCVsbiyn1hmXVCPouBWKiz
@sinelaw
sinelaw disabled auto-merge November 17, 2026 14:53
@sinelaw
sinelaw merged commit 444fe5c into master Nov 17, 2026
23 of 24 checks passed
@sinelaw
sinelaw deleted the fix/rustsec-zip-chrono branch November 17, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants