Repository navigation
agent: retry deadlocked PostgreSQL transactions, fail batches rolled back after an error - #2082
Draft
evgeny-simplex wants to merge 11 commits into
Draft
evgeny-simplex wants to merge 11 commits into
evgeny-simplex wants to merge 11 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On PostgreSQL, an agent transaction aborted by a deadlock was reported as INTERNAL instead of retried: in simplex-chat CI, the deletion of a delivered message and the deletion of its user deadlocked, and "delete user" failed (https://github.com/simplex-chat/simplex-chat/actions/runs/44067923868). And after a database error caught inside a transaction, PostgreSQL rolled the whole transaction back at COMMIT, while the batch items before the error were returned as saved.
Changes
withStore,unsafeWithStoreandwithStoreBatchretry a transaction aborted by a deadlock or a serialization conflict (40P01, 40001) up to 3 times, aswithTransactionIsolationalready did for repeatable read. The handlers inside transactions (batch items, message storage, expired message deletion, record creation) let these conflicts reach the retry. SQLite is unchanged.withStoreBatch, message storage inenqueueMessageB) returns every item as failed, "transaction rolled back after ...", as the transaction is rolled back; rolled-back messages are not submitted for delivery.Tests