Repository navigation
agent: prevent deletion from waiting for space in the event queue - #2076
Closed
evgeny-simplex wants to merge 2 commits into
Closed
evgeny-simplex wants to merge 2 commits into
evgeny-simplex wants to merge 2 commits into
Conversation
Contributor
Author
|
Replaced by #2079. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deleteConnectionsAsyncwroteDEL_CONNSfor connections without a receive queue or without an agent record to the event queue in the calling thread, anddeleteUserwroteDEL_USERfor a user without connections in the same way. When the queue was full, the calling thread waited until the application read events; simplex-chat makes these calls while holding a lock that its event thread can wait for, so neither thread proceeded.Change: both events are written with
nonBlockingWriteTBQueue, as other events written in API calls: in the calling thread while the queue has space, as before, otherwise by a separate thread once the queue has space.Tests: two tests fill the event queue, check that the deletion returns, then read the event.