Skip to content

Drop support for OCaml 4.7 to 4.10 + Cleanup - #36

Merged
rlepigre merged 4 commits into
masterfrom
cleanup
Nov 3, 2026
Merged

rlepigre merged 4 commits into
masterfrom
cleanup

Conversation

@rlepigre

@rlepigre rlepigre commented May 1, 2024

Copy link
Copy Markdown
Owner

These versions are probably obsolete at this point, and this allows simplifying the code slightly.

@rlepigre
rlepigre requested a review from craff May 1, 2024 06:45
@craff craff self-assigned this Jul 5, 2024

@craff craff left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got, just one remark to add 5.2.0 to workflow, but not really necessary in this PR.

Comment thread .github/workflows/ci.yml Resolved
@rlepigre

rlepigre commented Jul 5, 2024

Copy link
Copy Markdown
Owner Author

Got, just one remark to add 5.2.0 to workflow, but not really necessary in this PR.

I added it, could you approve the PR? Merging currently requires approval, but if that gets too annoying I'll disable this.

@craff

craff commented Jul 6, 2024 via email

Copy link
Copy Markdown
Collaborator

We do not run benchmarks as the container does not seem to let us
run perf by default, and we don't care much to run benchmarks all
the time anyway.
@rlepigre
rlepigre merged commit 3109ffe into master Nov 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants