Repository navigation
Leave the redhat containers out of the test matrix when the secrets are missing - #508
Merged
gaborcsardi merged 3 commits intoNov 7, 2026
Conversation
The redhat/ubi* test jobs register the container with subscription-manager, using the REDHAT_* secrets. A pull request from a fork gets no secrets, so those six jobs failed before running a test, on every fork PR (r-lib#490, r-lib#492, r-lib#507). The matrix setup now leaves the redhat/* containers out when REDHAT_ORG is empty; pushes, scheduled runs and in-repo branches still run them.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
=======================================
Coverage 65.48% 65.48%
=======================================
Files 91 91
Lines 47600 47600
=======================================
Hits 31169 31169
Misses 16431 16431 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Thanks! In general I suggest to push to a branch inside the repo if you have write access to r-lib, then there is no issue with secrets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
redhat/ubi8,redhat/ubi9andredhat/ubi10test jobs register the container withsubscription-manager, using theREDHAT_ORGandREDHAT_ACTIVATION_KEY_RHEL*secrets (theENVSblock in the Makefile, read bytests/test-linux-docker.sh). A pull request from a fork gets no repository secrets, so on every fork PR all six of those jobs stop before running a single test:That is what happened on #490, #492 and #507.
This leaves the
redhat/*containers out of the matrix whenREDHAT_ORGis empty, in both the x86_64 and the aarch64 matrix setup steps, so the jobs are absent rather than red. Pushes, scheduled runs,workflow_dispatchand in-repo branches have the secret and keep running them.Since this PR comes from a fork, its own run shows the effect: the Linux container jobs should list the other fifteen containers and no
redhat/*ones, and the setup step logsREDHAT_ORG is not available, leaving out the redhat/* containers.