Repository navigation
Update QOI pixel index for run chunks - #10454
Closed
lianxiaozhi wants to merge 1 commit into
Closed
lianxiaozhi wants to merge 1 commit into
lianxiaozhi wants to merge 1 commit into
Conversation
Author
|
Closing in favor of #10453, which was opened first and contains the same decoder fix. Thanks @manit2004 for the report and fix. The additional regression coverage and release note are available separately in lianxiaozhi@0078905, based on the author's PR head. This commit changes only the tests and release note, so it can be reused without duplicating the decoder change. The local validation results are recorded in this PR's description and in the follow-up on #10452. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10452.
QOI_OP_RUN skips the shared pixel-index update. An initial run of opaque black followed by a later INDEX reference can therefore decode as transparent black. This applies the fix suggested by @manit2004 in the report.
Changes proposed in this pull request:
Validation on macOS arm64 with Python 3.11.15, using a full editable source build of Pillow 13.1.0.dev0 and its native extensions:
tox -e lintandtox -e mypy: passed.edgecase.qoi, which failed before the fix.