Repository navigation
Support pandas nullable dtypes in safe_issubdtype - #282
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
safe_issubdtypepasses pandas extension dtypes such asBooleanDtype,Int64Dtypeand pyarrowbool[pyarrow]tonp.issubdtype, which raisesTypeError: Cannot interpret 'BooleanDtype' as a data type. Because the categorical sniffer andcategorical_to_intcall it on the raw Series dtype,dmatrix("b", df)on a nullable boolean column anddmatrix("C(i)", df)on a nullable integer column fail, even without missing values.DataFrame.convert_dtypes()produces these dtypes.This change uses the dtype's
numpy_dtypeattribute when it exists, before the call tonp.issubdtype. Plain numpy dtypes don't have this attribute, so their behavior doesn't change.Tests
test_safe_issubdtypecoversBooleanDtypeandInt64Dtype.test_pandas_nullable_dtypesbuilds design matrices from nullable boolean and integer columns.Both tests fail without the fix and pass with it. The full suite passes with numpy 2.5.4 and pandas 3.1.0, with numpy 1.26.4 and pandas 1.5.3, and without pandas.
Columns that contain
pd.NAare out of scope. patsy doesn't yet treatpd.NAas missing for any dtype.Fixes #281