Repository navigation
Add the core Splitter to the block library - #347
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Splitter moved from pathsim-chem to pathsim core (0.29). pathsim-chem 0.4 only keeps a deprecated alias, so the block was missing from the library and saved diagrams failed with
Unknown node type: Splitter. It is now listed with the core algebraic blocks. Same ports as before (in, variable outputs), old diagrams load and run unchanged.Also anchors the parameter name at the start of a line in
param_desc, so a name inside the docstring text is no longer taken as its description (Splittercarrier, andd,e,rof some pathsim-chem blocks). The regenerated files also pick up the current version and registry entries.