Skip to content

Retry creating the linker's temp directory when access is denied - #741

Open
elle-j wants to merge 2 commits into
mainfrom
lj/fix-linker-temp-dir
Open

elle-j wants to merge 2 commits into
mainfrom
lj/fix-linker-temp-dir

Conversation

@elle-j

@elle-j elle-j commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Description

The bytecode hash comparison on main failed in this run in mode NY M3 S+ (we only test that mode on main). The Windows build didn't compile some contracts due to access being denied for the linker's temporary directory.

This seems to be an intermittent failure, and not caused by the PR that triggered the run. (A full rerun of all test jobs passed.)

tempfile only retries with a new name when the name already exists, but Windows reports a clash with a directory that is still being deleted as access denied, which may be the cause.

Changes summary:

  • ElfLinker::setup now retries creating the directory when access is denied, with a new random name (up to 3 retries).
  • Other errors are reported as before.

@elle-j
elle-j requested a review from xermicus November 16, 2026 11:19

@xermicus xermicus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead find and address the root cause?

@elle-j

elle-j commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

Will do 👍

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants