Skip to content

NY: look up LLVM functions by Id - #731

Merged
xermicus merged 3 commits into
mainfrom
cl/ny-same-name-sibling-functions
Nov 16, 2026
Merged

xermicus merged 3 commits into
mainfrom
cl/ny-same-name-sibling-functions

Conversation

@xermicus

Copy link
Copy Markdown
Member

Closes #696

Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
@xermicus
xermicus requested review from elle-j and jubnzv November 12, 2026 13:51

@elle-j elle-j left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nits:

  • newyork IR dumps currently show calls to same-named functions identically, so you can't see which function it actually refers to.
    • We could consider updating fn write_object() to count each name and keep inserting function.name when there are no collisions, otherwise with e.g. a _func_<id> postfix (to match this).
  • The PR title mentions llvm-context but updating it to newyork is probably more accurate (the Yul pipeline was already correct I believe).

@xermicus xermicus changed the title llvm-context: look up LLVM functions by Id NY: look up LLVM functions by Id Nov 16, 2026
@xermicus

Copy link
Copy Markdown
Member Author

Nice catch RE the title! Brain short-circuit

Signed-off-by: xermicus <cyrill@parity.io>
@xermicus
xermicus merged commit 5c7b935 into main Nov 16, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--newyork runs the first of two same-named Yul functions in sibling blocks for calls to both

2 participants