Repository navigation
NY: look up LLVM functions by Id - #731
Merged
Merged
Conversation
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
elle-j
approved these changes
Nov 13, 2026
elle-j
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Nits:
- newyork IR dumps currently show calls to same-named functions identically, so you can't see which function it actually refers to.
- We could consider updating
fn write_object()to count each name and keep insertingfunction.namewhen there are no collisions, otherwise with e.g. a_func_<id>postfix (to match this).
- We could consider updating
- The PR title mentions
llvm-contextbut updating it to newyork is probably more accurate (the Yul pipeline was already correct I believe).
Member
Author
|
Nice catch RE the title! Brain short-circuit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #696