Skip to content

Resize panel container after context is created - #558

Merged
RytoEX merged 1 commit into
obsproject:masterfrom
WizardCM:resize-panel-on-init
Oct 28, 2026
Merged

RytoEX merged 1 commit into
obsproject:masterfrom
WizardCM:resize-panel-on-init

Conversation

@WizardCM

Copy link
Copy Markdown
Member

Description

Work around a race condition where the call to Resize() could occur before the browser context existed, resulting in the default size 100x30 until next manual resize of the parent window or dock.

The wrapper container and Resize() function are only used on non-macOS platforms.

Motivation and Context

Browser docks should always reflect the size of the dock they're in.

I've been able to reproduce this on Linux about 70% of the time.

image

GammaRay insight:

image image

r1ch was able to reproduce this pretty consistently on Windows, though I have not.

image

Note: This does not fix a separate issue where the dock doesn't immediately resize to fit the parent container when docking on Linux.

How Has This Been Tested?

Repeatedly relaunch OBS on Windows and Linux. For the latter, run in X11 mode to get access to browser docks.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@github-project-automation github-project-automation Bot moved this from Ready For Review to Ready For Merge in Current Release Tracker (33.0) Oct 28, 2026
@Warchamp7 Warchamp7 added the kind/bug Categorizes issue or PR as related to a bug. label Oct 28, 2026
Comment thread panel/browser-panel-client.cpp Resolved
Comment thread panel/browser-panel-client.hpp Resolved
Work around a race condition where the call to Resize() could occur
before the browser context existed, resulting in the default size 100x30
until next manual resize of the parent window or dock.

The wrapper container and Resize() function are only used on non-macOS
platforms.
@RytoEX
RytoEX force-pushed the resize-panel-on-init branch from 2cbd9ac to e71644f Compare October 28, 2026 19:37

@RytoEX RytoEX left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed up the commit message. LGTM

@RytoEX
RytoEX merged commit be39477 into obsproject:master Oct 28, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from Ready For Merge to Merged in Current Release Tracker (33.0) Oct 28, 2026
@WizardCM
WizardCM deleted the resize-panel-on-init branch November 7, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug.

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

3 participants