Repository navigation
feat: remove aix flaky tests on body-parser - #1224
Open
UlisesGascon wants to merge 2 commits into
Open
UlisesGascon wants to merge 2 commits into
UlisesGascon wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1224 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 29 29
Lines 2213 2213
=======================================
Hits 2127 2127
Misses 86 86 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
BethGriggs
approved these changes
Nov 5, 2026
BethGriggs
left a comment
BethGriggs
left a comment
Member
There was a problem hiding this comment.
Confirmed passing on all versions on AIX now:
MikeMcC399
suggested changes
Nov 6, 2026
MikeMcC399
left a comment
MikeMcC399
left a comment
Contributor
There was a problem hiding this comment.
The commit message of this PR needs to be changed to lookup: otherwise it will trigger a minor version update when merged (unless it's manually corrected during merge), which is too high for this change.
Also, in the meantime, the maintainers have been updated to
"maintainers": ["jonchurch", "UlisesGascon"]which is causing GitHub to report a conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think that body-parser is stable enough, but let's check the reports 👍