Repository navigation
Conversation
Entries in a module's `scripts` array may now be an object of the form
`{ "script": "name", "skip": <condition> }`,
where `skip` accepts the same conditions as the top-level `skip`.
Use this to skip `posttest` for `resolve` on win32.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1191 +/- ##
==========================================
+ Coverage 96.11% 96.15% +0.03%
==========================================
Files 29 29
Lines 2213 2235 +22
==========================================
+ Hits 2127 2149 +22
Misses 86 86 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
I’m somewhat neutral on this as I am thinking about how often it would be used. Adding more mechanisms to skip tests adds complexity to understanding what’s being run and where. Do we think it’s worthwhile, even if it was just used for resolve? Just thinking it through. |
Member
Author
|
The way I think about it is, this maximizes test coverage while still allowing skips - otherwise, the script is skipped needlessly on N platforms when it only needs to be skipped on 1. |
ljharb
force-pushed
the
lookup-scripts-skip
branch
from
November 2, 2026 22:23
b95c40c to
9fd5704
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entries in a module's
scriptsarray may now be an object of the form{ "script": "name", "skip": <condition> },where
skipaccepts the same conditions as the top-levelskip. Use this to skipposttestforresolveon win32.ref #1182 (comment)