[sleepyStick]

PYTHON-6028

Changes in this PR

Test Plan

Checklist

Checklist for Author

• Did you update the changelog (if necessary)?
• Is there test coverage?
• Is any followup work tracked in a JIRA ticket? If so, add link(s).

Checklist for Reviewer

• Does the title of the PR reference a JIRA Ticket?
• Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
• Is all relevant documentation (README or docstring) updated?

[Copilot]

🟡 Changes recommended

The retry helper subclass lacks __slots__ = (), introducing an instance dictionary and avoidable per-operation memory overhead despite its slotted base.

1 open issue

• Add slots to keep retry helper instances compact · New

What changed in this PR

This PR consolidates non-I/O retry logic into a shared base class used by PyMongo’s asynchronous and synchronous clients.

Changes:

• Moves retry-state initialization, eligibility checks, last-error handling, and retry logging into _AgnosticClientConnectionRetryableBase.
• Updates both client helpers to inherit shared behavior while retaining their I/O-specific implementations.

File	Description
pymongo/​synchronous/​mongo_client.py	Updates the generated synchronous helper to inherit the shared base.
pymongo/​mongo_client_shared.py	Adds the generic base class containing common retry state and logic.
pymongo/​asynchronous/​mongo_client.py	Replaces duplicated non-I/O logic with inheritance from the shared base.

_{Review effort: Balanced}

[NoahStapp]

These should all be under if TYPE_CHECKING since they're used purely for type hints.

[sleepyStick]

ah good catch, fixed in 485777e

[NoahStapp]

I don't think we need Generic[T] here since the parent class is already Generic[T].

[sleepyStick]

makes sense, removed in 485777e

[NoahStapp]

Intentional to include these changes here?

[sleepyStick]

🤦 that was entirely accidental 😭
should be gone now!!