[payamsash]

Reference issue (if any)

following #14412 and phase 7 of #14141

What does this implement/fix?

Load and saving the scaling from the GUI.

@nordme Can you please give it a try when you have time. Thanks

[nordme]

@payamsash Thanks, yep, I'll review tomorrow (Friday)! 😄

[nordme]

Hi @payamsash ! Ok, I test drove the scaling loading button and confirmed that it loads a scaling when my subject is a template and I type the name of a scaled subject into the scaling subject name field. The tooltip appears correctly.

I think I had a different idea of how this feature would work based on my common use case, so let me ask you about your common use case.

My common use case: I pull up a previously scaled subject with its own anat, e.g. "subject_101." The subject appears and the figure is rendered properly scaled. However, I can't see what the numerical scaling values are relative to the original template, e.g. fsaverage, in the scaling fields to the right. I would like to see what the scalings are, so I enter the subject name, "subject_101", in the field and click "load scaling". <--- This does not work with your current implementation. The load scalings button is greyed out.

What is your common use case? I can see that you need to have a template loaded in order to then type a different subject's name into the scaling field -- this allows the load scaling button to be clicked. But typically, when I'm revisiting a subject I already scaled, I load the scaled anat, not the template. What was your motivating use case scenario for this button?

[payamsash]

My idea was that user could open the template, type the scaled subject's name, load its scaling, refine it, then overwrite it. But I agree that your suggested workflow could be more common. Please give it another try. Thanks in advance

[nordme]

Hi @payam! Sorry it took me a bit to get to this.

Alright, I tried it out the latest commit, but now it's got some unexpected behavior. When I load my scaled subject, e.g. "subject_101", type in the subject's name next to the load scalings button, then hit "load scalings", coreg loads up fsaverage, i.e. it changes the subject, and it loses the fiducials. So that's not ideal behavior, I think! If we're going to load the scalings while viewing the scaled subject, we'd better keep the scaled subject as the subject.

It occurs to me that maybe there should be a field showing what template was originally used to do the scaling, placed near the scaling fields, that populates after hitting the load scalings button, to help users understand that the scaling values are in reference to the original template. What do you think, Payam?

[payamsash]

Thank you @nordme, I agree with you. Now the "Load scaling" button should keep the scaled subject open and the fiducilas, trans and scale fields should not change. Also you should see sth like "Scaled from fsaverage: X %" as you suggested.