Repository navigation
test: repair release-gate integration oracles after 0.37 owner changes - #4072
Open
Daniel Meppiel (danielmeppiel) wants to merge 3 commits into
Open
Daniel Meppiel (danielmeppiel) wants to merge 3 commits into
Daniel Meppiel (danielmeppiel) wants to merge 3 commits into
Conversation
Daniel Meppiel (danielmeppiel)
requested a review
from Sergio Sisternes (sergio-sisternes-epam)
as a code owner
November 20, 2026 05:20
…r the marketplace reinstall oracle A rebuilt but unchanged LockFile (apm_version None) dropped the recorded stamp on write, so its bytes changed and the generator gate lost its signal. The no-op path now carries the recorded stamp, like generated_at. The marketplace reinstall e2e patched only the resolver's registry lookup; #3959's origin check reads the same registration through catalog_origin, so it is patched too (the check still runs). apm-spec-waiver: lockfile no-op write keeps existing stamp; test oracle repair only Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- default client is copilot; vscode is its deprecated alias (#3875) - non-default port is part of the lock identity key (#3932); the roundtrip still writes and reads port: 7990 - a partial `apm marketplace update` fails closed with exit 1 and names the failed catalog (#3910) - Claude's skill-command rewrite is an instance method that needs the project's .claude/skills copy (#3875) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
… asserts the owner route Fragments in ci_checks.py, audit.py, local_bundle_handler.py and local_bundle.py drifted; each mutation now targets the current equivalent line and the guard still trips. install-deployment-audit-policy-discovery only banned discover_policy(, so deleting chain discovery from _audit_ci_gate passed silently. The rule now also requires discover_policy_with_chain( inside _audit_ci_gate. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Daniel Meppiel (danielmeppiel)
force-pushed
the
danielmeppiel-release-gate-oracles
branch
from
November 20, 2026 05:43
93e75a5 to
25325ba
Compare
Daniel Meppiel (danielmeppiel)
added a commit
that referenced
this pull request
Nov 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Repairs the 11 integration tests the daily release smoke (run 44672011093) fails on main and on the 0.37 train, so the v0.37.0 tag run is green. Each test was classified as a STALE ORACLE (the test is updated to the current contract) or a REAL REGRESSION (the owner is fixed). No security assertion is weakened.
test_lifecycle_state_snapshot_contract.py::test_semantic_state_ignores_yaml_formatting_and_generated_timeLockFiledropped the recordedapm_version, which changed the bytes and blinded the generator gate.LockFile.writenow keeps the recorded stamp on a no-op, as it does forgenerated_at. A new unit test fails on base.test_marketplace_ref_install_e2e.py::test_github_family_marketplace_registered_ref_reaches_downloadercatalog_origin. The test now patches that lookup as well as the resolver's, so the origin check still runs and passes.test_architecture_install_compound_mutations.py[audit-replay-config-modules-root]prepared_replay.modules_rootline. The guard still catches the mutation.test_architecture_semantic_rule_mutations.py[install-deployment-audit-policy-discovery]discover_policy_with_chain(call. The rule now also requires that call in_audit_ci_gate, so deleting it trips the linter.test_commands_config_coverage.py::test_get_default_client_returns_vscode..._returns_copilot; it assertscopilot.test_default_port_normalisation_e2e.py::test_lockfile_yaml_roundtrip_preserves_non_default_portport: 7990, keyhost:7990/team/repo). The lookup now usesget_unique_key().test_marketplace_e2e_surface.py::test_update_all_with_source_exception_verbose,test_wave7_marketplace_install_coverage.py::test_update_partial_failuretest_wave2_adapters_coverage.py::TestClaudeClientAdapter::test_rewrite_self_defined_skill_command_{converged,other}[audit-replay-config-fallback-hardcoded]; semantic[local-bundle-policy-preflight],[registry_delegation.lockfile_version_authority]Issue and approved scope
Issue: Refs #3983 (release-gate repair for the 0.37 owner changes; requested by the 0.37 delivery manager before the tag).
Human scope-approval comment: #3983 scope records; delivery manager pre-tag request.
Does this PR complete the issue, or what remains? It restores the release smoke. #3983 remains the umbrella.
Type of change
Testing
Run at the head with
APM_E2E_TESTS=1 APM_RUN_INTEGRATION_TESTS=1 APM_BINARY_PATH=<this tree> GITHUB_APM_PAT=...:pytest -n 2over the named test files, plustests/unit/deps/test_lockfile_generator.pyandtests/unit/scripts/test_architecture_runner.py: 1145 passed.scripts/lint-architecture-boundaries.sh: exit 0.Changelog
## [Unreleased]Spec conformance (OpenAPM v0.1)
No
req-XXXbehaviour changes.