Skip to content

test: repair release-gate integration oracles after 0.37 owner changes - #4072

Open
Daniel Meppiel (danielmeppiel) wants to merge 3 commits into
danielmeppiel-4027-part2from
danielmeppiel-release-gate-oracles
Open

Daniel Meppiel (danielmeppiel) wants to merge 3 commits into
danielmeppiel-4027-part2from
danielmeppiel-release-gate-oracles

Conversation

@danielmeppiel

Copy link
Copy Markdown
Collaborator

Description

Repairs the 11 integration tests the daily release smoke (run 44672011093) fails on main and on the 0.37 train, so the v0.37.0 tag run is green. Each test was classified as a STALE ORACLE (the test is updated to the current contract) or a REAL REGRESSION (the owner is fixed). No security assertion is weakened.

# Test Verdict Change
6 test_lifecycle_state_snapshot_contract.py::test_semantic_state_ignores_yaml_formatting_and_generated_time Real regression (#3962 stamp) A semantic no-op write from a freshly built LockFile dropped the recorded apm_version, which changed the bytes and blinded the generator gate. LockFile.write now keeps the recorded stamp on a no-op, as it does for generated_at. A new unit test fails on base.
8 test_marketplace_ref_install_e2e.py::test_github_family_marketplace_registered_ref_reaches_downloader Stale patch point The reinstall runs the #3959 origin check, which reads the registration through catalog_origin. The test now patches that lookup as well as the resolver's, so the origin check still runs and passes.
1 test_architecture_install_compound_mutations.py[audit-replay-config-modules-root] Stale fragment Re-pointed at the current prepared_replay.modules_root line. The guard still catches the mutation.
2-3 test_architecture_semantic_rule_mutations.py[install-deployment-audit-policy-discovery] Stale fragment plus a guard gap Re-pointed at audit's current discover_policy_with_chain( call. The rule now also requires that call in _audit_ci_gate, so deleting it trips the linter.
4 test_commands_config_coverage.py::test_get_default_client_returns_vscode Stale (#3875) Renamed ..._returns_copilot; it asserts copilot.
5 test_default_port_normalisation_e2e.py::test_lockfile_yaml_roundtrip_preserves_non_default_port Stale (#3932) I verified the port survives the roundtrip (port: 7990, key host:7990/team/repo). The lookup now uses get_unique_key().
7, 11 test_marketplace_e2e_surface.py::test_update_all_with_source_exception_verbose, test_wave7_marketplace_install_coverage.py::test_update_partial_failure Stale: fail-closed is intended (#3910; the CHANGELOG already states it) They assert exit 1, name the failure, and check that the healthy marketplace still refreshes.
9-10 test_wave2_adapters_coverage.py::TestClaudeClientAdapter::test_rewrite_self_defined_skill_command_{converged,other} Stale (#3875 signature) Use the current instance method; the assertions are unchanged.
extra compound [audit-replay-config-fallback-hardcoded]; semantic [local-bundle-policy-preflight], [registry_delegation.lockfile_version_authority] Stale fragments Re-pointed. Each guard still catches its mutation.

Issue and approved scope

Issue: Refs #3983 (release-gate repair for the 0.37 owner changes; requested by the 0.37 delivery manager before the tag).

Human scope-approval comment: #3983 scope records; delivery manager pre-tag request.

Does this PR complete the issue, or what remains? It restores the release smoke. #3983 remains the umbrella.

Type of change

  • Bug fix
  • New feature
  • Documentation
  • Maintenance / refactor

Testing

  • Tested locally
  • All existing tests pass (CI)
  • Added tests for new functionality (if applicable)

Run at the head with APM_E2E_TESTS=1 APM_RUN_INTEGRATION_TESTS=1 APM_BINARY_PATH=<this tree> GITHUB_APM_PAT=...:

  • pytest -n 2 over the named test files, plus tests/unit/deps/test_lockfile_generator.py and tests/unit/scripts/test_architecture_runner.py: 1145 passed.
  • ruff 0.15.12 check and format --check: clean.
  • scripts/lint-architecture-boundaries.sh: exit 0.
  • pylint R0801: 10.00/10.

Changelog

Spec conformance (OpenAPM v0.1)

No req-XXX behaviour changes.

…r the marketplace reinstall oracle

A rebuilt but unchanged LockFile (apm_version None) dropped the recorded
stamp on write, so its bytes changed and the generator gate lost its
signal. The no-op path now carries the recorded stamp, like generated_at.

The marketplace reinstall e2e patched only the resolver's registry
lookup; #3959's origin check reads the same registration through
catalog_origin, so it is patched too (the check still runs).

apm-spec-waiver: lockfile no-op write keeps existing stamp; test oracle repair only

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- default client is copilot; vscode is its deprecated alias (#3875)
- non-default port is part of the lock identity key (#3932); the roundtrip
  still writes and reads port: 7990
- a partial `apm marketplace update` fails closed with exit 1 and names
  the failed catalog (#3910)
- Claude's skill-command rewrite is an instance method that needs the
  project's .claude/skills copy (#3875)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
… asserts the owner route

Fragments in ci_checks.py, audit.py, local_bundle_handler.py and
local_bundle.py drifted; each mutation now targets the current
equivalent line and the guard still trips.

install-deployment-audit-policy-discovery only banned discover_policy(,
so deleting chain discovery from _audit_ci_gate passed silently. The
rule now also requires discover_policy_with_chain( inside _audit_ci_gate.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@danielmeppiel
Daniel Meppiel (danielmeppiel) force-pushed the danielmeppiel-release-gate-oracles branch from 93e75a5 to 25325ba Compare November 20, 2026 05:43
Daniel Meppiel (danielmeppiel) added a commit that referenced this pull request Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant