Repository navigation
Conversation
ddupg
marked this pull request as ready for review
November 20, 2026 02:32
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #11273.
What problem does this solve?
FTS merge, update, and remap can write one posting format to disk and report another in the dataset manifest. For example, merging a V3 text index with 128-document blocks preserves V3 in the files but reports V2. The same mismatch can make a V1 segment pass the query planner’s V2/V3 check for cross-column FTS.
What changed?
Build the returned index details from the writer’s resolved posting format. Previously, maintenance reconstructed the format from stored tokenizer parameters, which omit the explicit version and default to V2 for text with 128-document blocks.
How was this tested?
Regression tests verify that merge, update, and remap report the posting format read back from the output files.
All nine targeted tests passed. Workspace Clippy stopped on two existing unreachable expressions in
lance-encoding/src/encodings/physical/byte_stream_split.rson macOS arm64.