Repository navigation
Conversation
ddupg
marked this pull request as ready for review
November 20, 2026 02:24
ddupg
force-pushed
the
fix/label-list-null-children
branch
from
November 20, 2026 03:28
0ef0112 to
703b098
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #11273.
Arrow permits a null list to span a non-empty range in the child array. LabelList used the offsets alone when flattening lists, so a label stored under a null parent could acquire a posting for that row.
Build and update now read each parent row's address once during list expansion. A valid list pairs its labels with that address. A null list contributes its address to the list-null bitmap and emits no postings. The expansion reuses the sliced child array when there are no hidden values to remove.
The regression test inspects the stored index for both List and LargeList. It checks that a hidden label has no posting, the null list is still recorded, and a null element inside a valid list retains its posting.
All 23 LabelList unit tests passed locally, including both new regression cases. Formatting passed. Workspace Clippy on macOS arm64 stopped in unchanged byte_stream_split.rs at lines 358 and 393 (unreachable expressions after the NEON dispatch).