Repository navigation
Conversation
ddupg
force-pushed
the
fix/stable-row-id-full-selection
branch
from
November 20, 2026 01:05
4c79bdc to
be14f1c
Compare
ddupg
marked this pull request as ready for review
November 20, 2026 01:06
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting a row leaves its stable ID in the fragment’s row ID sequence. When a scalar index selects the whole fragment, address-to-ID translation copies that sequence and includes the deleted row. Selecting the same physical offsets individually already skips it (#7918).
Apply the fragment’s deletion vector before adding its IDs to the result. With no deletions, the existing range-based conversion is unchanged. With deletions, only the deleted offsets need individual translation.
The regression test deletes ID 7 from a fragment containing IDs 5–9. On
main, whole-fragment translation returned[5, 6, 7, 8, 9]. With this change, both selection forms returned[5, 6, 8, 9].cargo fmt --alland Clippy for thelancecrate (library and tests) passed. Workspace Clippy on macOS arm64 stops on existing unreachable expressions inbyte_stream_split.rs(lines 358 and 393).Extracted from #11273.