Repository navigation
Conversation
Xuanwo
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11265
What changes
optimize_options()raisesValueError: Invalid optimize_indices option: <key>for a key it does not know, asparse_compaction_optionsdoes.DatasetOptimizer.optimize_indices,OptimizeIndices.planandOptimizeIndices.commitall parse through it.DatasetOptimizer.optimize_indicestakes its six options as keyword-only parameters, likecompact_files, so a typo raisesTypeErrorbefore reaching the binding.Nonemeans unset in every entry point. Before,retrain=Noneandindex_names=NoneraisedTypeErrororValueError.retraindocs in Rust, Python and Java say that only vector indices are retrained. The Rust note "only supported for v3 vector indices" predates the current rebuild-from-source retrain. A legacy-format vector index panics on retrain until fix(index): optimize legacy IVF segments and uint8 IVF_HNSW_FLAT indexes without panicking #11263 lands.A caller that passed an option name
optimize_indicesdoes not know now gets an error instead of a default optimize. No option in the repository or in lance-ray does.Tests
test_optimize_indices_rejects_unknown_optionspasses a misspelledindex_nameto all four entry points (the Python method, the binding,plan,commit) and checks that each raises and nothing is committed. It then checks thatNonevalues are accepted byplanand byoptimize_indices, and that the correctly spelled option optimizes.🤖 Generated with Claude Opus