Skip to content

feat(transaction): retry an action set that only fails at the latest version - #11240

Draft
wjones127 wants to merge 1 commit into
will/oss-2605-parity-harnessfrom
will/conflict-apply-retry
Draft

wjones127 wants to merge 1 commit into
will/oss-2605-parity-harnessfrom
will/conflict-apply-retry

Conversation

@wjones127

Copy link
Copy Markdown
Contributor

Summary

When an action set fails to apply on the latest version, the commit now checks whether it applies on the version it read. If it does, a concurrent commit broke it, so the failure is returned as a retryable commit conflict instead of the original error. If it fails at its read version too, the original error is returned unchanged.

This lets the conflict check rely on apply for what apply already validates (a missing fragment, field or base), instead of restating those checks.

Evidence

io::commit::tests::test_failed_apply_is_retryable_only_if_it_applies_at_read_version, which runs on an in-memory dataset:

  • applies_at_read_version expects RetryableCommitConflict at the latest version.
  • fails_at_read_version_too expects the original InvalidInput.

The first case fails with the check disabled.

Merge Risk

Door: two-way. Only the error kind returned for a failed action-set apply changes.
Blast Radius: concurrency (commit retry of action sets).

🤖 Generated with Claude Code

… not the latest is a retryable conflict

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the enhancement New feature or request label Nov 19, 2026
@wjones127
wjones127 added this pull request to stack #11242 November 19, 2026 02:02

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant