Skip to content

docs: revert three-layer stack split and restore engine-first quickstart order - #10692

Merged
Xuanwo merged 1 commit into
mainfrom
xuanwo/revert-docs-stack-reorg
Nov 3, 2026
Merged

Xuanwo merged 1 commit into
mainfrom
xuanwo/revert-docs-stack-reorg

Conversation

@Xuanwo

@Xuanwo Xuanwo commented Nov 3, 2026

Copy link
Copy Markdown
Member

Address post-merge review feedback on #10672 (and clean up the unused track-switcher code left behind after #10628 was reverted in #10674):

  • Restore docs/src/quickstart/index.md to the LanceDB quickstart landing page (removing the split lancedb.md and three-layer stack overview) and order engines (LanceDB, Apache Spark) ahead of the low-level format SDKs (PyLance, Rust, Java) in docs/src/quickstart/.pages and the intro guidance.
  • Remove the Database / Language SDKs / Query & Compute Engines three-layer split from docs/src/integrations/ (index.md, .pages, clean-full-website.sh, make-full-website.sh) and from the homepage ecosystem section (docs/theme/home.html), restoring the standalone SDK Docs top-nav entry in docs/src/.pages.
  • Remove the unused .ld-sidenav__tracks sidebar switcher added for docs: add LanceDB and Apache Spark options to user guide #10628 while keeping the CI-tested Rust/Java/PyLance quickstart snippets, multi-language User Guide code tabs, collapsible <details> subsections, and strict docs-build.yml CI gate intact.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@github-actions github-actions Bot added A-docs Documentation documentation Improvements or additions to documentation labels Nov 3, 2026

@lance-gatekeeper lance-gatekeeper Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Gate recommendation: approve.

The revised navigation addresses the earlier feedback and preserves access to the tutorials and SDK references.

@lance-gatekeeper lance-gatekeeper Bot added the K-approved Latest Gatekeeper recommendation permits acceptance. label Nov 3, 2026
@Xuanwo
Xuanwo requested a review from wjones127 November 3, 2026 17:35
Comment thread docs/theme/main.html

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: should we keep the theme fixes? Or are these tied to the other changes?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, tied to other changes, we can add them back if we needed.

@Xuanwo
Xuanwo merged commit b88a70f into main Nov 3, 2026
11 checks passed
@Xuanwo
Xuanwo deleted the xuanwo/revert-docs-stack-reorg branch November 3, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-docs Documentation documentation Improvements or additions to documentation K-approved Latest Gatekeeper recommendation permits acceptance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants