Skip to content

test: hold Transaction V2 action sets to legacy conflict parity - #10159

Open
wjones127 wants to merge 2 commits into
will/transaction-v2-action-constructorsfrom
will/oss-2605-parity-harness
Open

wjones127 wants to merge 2 commits into
will/transaction-v2-action-constructorsfrom
will/oss-2605-parity-harness

Conversation

@wjones127

Copy link
Copy Markdown
Contributor

Summary

Adds a parity harness so each conflict-parity milestone can flip table cells instead of writing new tests. Transaction V2 action sets are staged as scenarios in #9220's end-to-end conflict matrix. Each one names the legacy scenarios it stands in for (Scenario::analogues). A new check fails any cell that is stricter than its legacy analogues' cells (Lands > Retryable > Incompatible), unless the cell is marked * as a known gap and has a reason in PARITY_GAPS.

                          | ap dl ... cf va vc v+
append                    | L  L  ... L  R* R* R*      <- legacy over action set
action_append             | R* R* ... R* L  L  L       <- action set over legacy / action
action_append_and_config  | R* R* ... R  L  R  R
  • Scenarios: action_append (AddFragment + AddDataFile, reusing the files a legacy append wrote), action_update_config (ConfigUpdate on the same schema-metadata key as update_config), and action_append_and_config (both in one commit, held to the stricter of Append and UpdateConfig).
  • The table is seeded with current behaviour. Action-vs-action pairs resolve as they do today. Every mixed pair fails closed in check_action_txn and is marked * wherever legacy does better.
  • Known gaps still run and assert today's verdict, so closing one means editing the grid. A * on a cell that is no longer a gap, or a PARITY_GAPS entry that no * cell uses, also fails.
  • Landed cells go through test: characterize legacy conflict resolution end to end #9220's invariant battery and oracle as before.
  • Renames test: characterize legacy conflict resolution end to end #9220's scenarios::Footprint to Placement so it doesn't clash with lance-table's Footprint.

The dataset-free footprint/verdict tier is left to conflict parity 1/5, which adds the APIs it would exercise.

Stacked: based on #8646 with #9220 merged in, so the diff also contains #9220's conflict_matrix module until that lands. This PR's own changes are the last two commits.

Evidence

cargo test -p lance --lib conflict_matrix: 53 tests pass in about 2s total. I checked that the reason check fails when a PARITY_GAPS entry is removed: (append over action_append_and_config) is marked * but neither side has a reason in PARITY_GAPS. Clippy was run on -p lance --tests, not the whole workspace.

Merge Risk

Door: two-way. Test-only.
Blast Radius: none.

🤖 Generated with Claude Code

@wjones127

Copy link
Copy Markdown
Contributor Author

Rebased onto current #8646 head (8a5f8fd). Re-merged #9220 (abde8dd) and added mem_wal_dir_id: None to its Update fixture. The action-append fixture is ported to UserStep/FieldRef, with AddDataFile.base and empty file.fields. No cell changes.

@wjones127
wjones127 force-pushed the will/oss-2605-parity-harness branch from 7c955f0 to e3a5eae Compare November 3, 2026 23:43
@wjones127
wjones127 force-pushed the will/oss-2605-parity-harness branch from e3a5eae to a594a8e Compare November 12, 2026 23:14
@github-actions github-actions Bot added A-index Vector index, linalg, tokenizer A-java Java bindings + JNI A-deps Dependency updates A-encoding Encoding, IO, file reader/writer A-format On-disk format: protos and format spec docs A-namespace Namespace impls A-ci CI / build workflows format-change A change to the format spec, which requires a vote. Remove if minor (e.g. fixing typo). labels Nov 16, 2026
@lance-gatekeeper lance-gatekeeper Bot removed the K-approved Latest Gatekeeper recommendation permits acceptance. label Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Important

Format specification vote

This PR modifies the Lance format specification, so it requires 3 binding +1 votes from PMC members (excluding the proposer), at least one of them on the latest commit, and a minimum 72-hour voting period, weekends excluded, before it can merge. Vote by approving this PR (+1) or requesting changes (−1, a veto). See the voting process.

Approvals carry over across pushes, so a rebase or a typo fix does not send everyone back to re-vote. Whoever approves the latest commit is vouching that nothing substantive has changed since the earlier approvals; if something has, ask for fresh votes.

Status: ❌ Blocked — 0 of 3 required approvals

Approvals none (0/3)
Latest commit approved by none — one PMC member must approve the latest commit
Vetoes none
Voting period ends Thu 2026-11-19 22:54 UTC (14:54 PST)

Updated automatically by the format-spec vote gate, which re-checks every 15 minutes — just voted? Re-check now (press Run workflow; leave the input blank to re-check every open format PR). A PMC member may apply the format-waived label to waive the vote for a trivial edit (typo, wording, formatting).

lance-gatekeeper[bot]

This comment was marked as outdated.

@lance-gatekeeper lance-gatekeeper Bot added the K-approved Latest Gatekeeper recommendation permits acceptance. label Nov 16, 2026
@wjones127
wjones127 force-pushed the will/oss-2605-parity-harness branch from 004163e to 474798e Compare November 17, 2026 19:25
@lance-gatekeeper lance-gatekeeper Bot removed the K-approved Latest Gatekeeper recommendation permits acceptance. label Nov 17, 2026
@codecov

codecov Bot commented Nov 17, 2026

Copy link
Copy Markdown

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

lance-gatekeeper[bot]

This comment was marked as outdated.

@lance-gatekeeper lance-gatekeeper Bot added the K-approved Latest Gatekeeper recommendation permits acceptance. label Nov 17, 2026
@wjones127
wjones127 force-pushed the will/oss-2605-parity-harness branch from 474798e to 5534a3d Compare November 17, 2026 20:00
@wjones127
wjones127 force-pushed the will/oss-2605-parity-harness branch from 5534a3d to e70e164 Compare November 17, 2026 21:58
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@wjones127
wjones127 force-pushed the will/oss-2605-parity-harness branch from e70e164 to becee80 Compare November 18, 2026 01:46
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lance-gatekeeper lance-gatekeeper Bot removed the K-approved Latest Gatekeeper recommendation permits acceptance. label Nov 19, 2026
@wjones127
wjones127 removed this pull request from stack #8647 November 19, 2026 02:01
@wjones127
wjones127 added this pull request to stack #11242 November 19, 2026 02:02

@lance-gatekeeper lance-gatekeeper Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Gate recommendation: approve.

No merge-blocking issues found in the test-only diff. Legacy expectations are preserved, and the focused matrix suite passes on the unmodified revision, including the new metadata and index/full-scan comparisons.

@lance-gatekeeper lance-gatekeeper Bot added the K-approved Latest Gatekeeper recommendation permits acceptance. label Nov 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci CI / build workflows A-deps Dependency updates A-encoding Encoding, IO, file reader/writer A-format On-disk format: protos and format spec docs A-index Vector index, linalg, tokenizer A-java Java bindings + JNI A-namespace Namespace impls A-python Python bindings chore format-change A change to the format spec, which requires a vote. Remove if minor (e.g. fixing typo). K-approved Latest Gatekeeper recommendation permits acceptance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant