Repository navigation
feat(datetime): enable range selection #31581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
OS-susmitabhowmik
wants to merge
107
commits into
next
Choose a base branch
from
ROU-12704-datepicker-range
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,103
−63
Open
Changes from all commits
Commits
Show all changes
107 commits
Select commit
Hold shift + click to select a range
478544c
feat(datetime): add DatetimeRangeParts interface for range selection
OS-susmitabhowmik a507212
feat(datetime): add selectionMode prop and deprecate multiple
OS-susmitabhowmik 1ab6897
feat(datetime): add range flags to getCalendarDayState
OS-susmitabhowmik bb61d21
feat(datetime): implement range selection logic
OS-susmitabhowmik 15aa4ae
feat(datetime): update calendar rendering for range selection
OS-susmitabhowmik cca6ee5
feat(datetime): add range highlight track styles
OS-susmitabhowmik f03eb37
feat(datetime): update header and datetime-button for range display
OS-susmitabhowmik 26b65a7
feat(datetime): disable confirm button until range is complete
OS-susmitabhowmik 8eb4d4e
test(datetime): add range and range-styling test pages
OS-susmitabhowmik 4d7abfc
fix(datetime): align range track styles with Figma design
OS-susmitabhowmik 9385623
fix(datetime): fix range style issues found during Figma validation
OS-susmitabhowmik 8236f7d
chore(datetime): update generated files for range selection API
OS-susmitabhowmik 581d280
chore(): add updated snapshots
Ionitron 9d70a28
Merge branch 'next' into ROU-12704-datepicker-range
OS-susmitabhowmik 5353064
fix(datetime): fix lint error and update state spec for range fields
OS-susmitabhowmik 405bac7
fix(toolbar): restore baseline snapshot from next branch
OS-susmitabhowmik e90b03c
Revert "fix(toolbar): restore baseline snapshot from next branch"
OS-susmitabhowmik 1b0efef
fix(datetime): fix SCSS lint property order and disallowed-list errors
OS-susmitabhowmik e07c496
chore(): add updated snapshots
Ionitron 2a7744b
fix(datetime): fix remaining SCSS lint order errors
OS-susmitabhowmik 47aa109
fix(datetime): apply prettier formatting to range files
OS-susmitabhowmik 2c61014
fix(datetime): use pill shapes for range on all themes and fix disabl…
OS-susmitabhowmik 1dbcd39
Merge branch 'next' into ROU-12704-datepicker-range
OS-susmitabhowmik 19d5c0e
fix(datetime): make month/year wheels navigation-only in range and mu…
OS-susmitabhowmik 91d19ed
fix(datetime): pass border-radius values as separate arguments for RT…
OS-susmitabhowmik 21d0dc2
fix(angular): add missing datetime props to standalone DATETIME_INPUT…
OS-susmitabhowmik 5ee1d71
fix(datetime): append both range labels for single-day range aria-label
OS-susmitabhowmik d917bd2
fix(datetime): prevent confirm from closing overlay with incomplete r…
OS-susmitabhowmik c1859c3
test(datetime): add e2e and unit tests for range selection mode
OS-susmitabhowmik 1ca8d38
refactor(datetime): simplify setActivePartsRange and rangeContainsDis…
OS-susmitabhowmik 4516f4f
fix(datetime): remove unused variables in range e2e tests
OS-susmitabhowmik 5b93e9a
fix(datetime): remove unused page param in readonly range test
OS-susmitabhowmik 133ac77
style(datetime): fix formatting in range e2e test fixture
OS-susmitabhowmik 621ecb0
fix(datetime): use dynamic selectors for no-value range e2e tests
OS-susmitabhowmik 609386d
style(datetime): fix indentation and remove extra blank line in setAc…
OS-susmitabhowmik 900707b
fix(datetime): remove unused datetime variable in ionChange range test
OS-susmitabhowmik e63b135
chore(): add updated snapshots
Ionitron 782299f
fix(datetime): fix range track subpixel gaps and iOS height
OS-susmitabhowmik 0f67fc5
chore(): add updated snapshots
Ionitron a1c43b3
fix(datetime): fix range track rendering on iOS
OS-susmitabhowmik e0550e4
chore(): add updated snapshots
Ionitron 4e27f4e
fix(datetime): fix range track subpixel gaps and iOS centering
OS-susmitabhowmik ddf6701
chore(): add updated snapshots
Ionitron c889e4a
test(datetime): add e2e tests for range selection aria labels
OS-susmitabhowmik 5c28e28
chore(datetime): remove outdated range e2e snapshots
OS-susmitabhowmik 60e3a89
style(datetime): fix formatting in range track background
OS-susmitabhowmik 047ec56
chore(): add updated snapshots
Ionitron e54e7b7
refactor(datetime-button): simplify range endDate lookup and remove u…
OS-susmitabhowmik f0d2627
fix(datetime): fix disabled opacity seams and empty range navigation
OS-susmitabhowmik 3da13e0
chore(): add updated snapshots
Ionitron c53ed45
test(datetime): add ionic-md mode to range visual regression tests
OS-susmitabhowmik 662f013
chore(): add updated snapshots
Ionitron 1cb5bb9
fix(datetime): stop cancel() from clearing a confirmed range selection
OS-susmitabhowmik 7aef96c
fix(datetime): scope disabled range grid opacity to ios/md themes only
OS-susmitabhowmik 3a651d6
test(datetime): strengthen range tests to fail without their fixes
OS-susmitabhowmik 1380043
chore(): add updated snapshots
Ionitron 427636b
test(datetime): add month wheel test for multiple mode in range tests
OS-susmitabhowmik 71891f1
fix(datetime): use circular range endpoints for ios/md and distinct c…
OS-susmitabhowmik 027b180
chore(): add updated snapshots
Ionitron b6087fd
fix(datetime): update range styles to match Figma design
OS-susmitabhowmik a373ddc
chore(): add updated snapshots
Ionitron 8b4de43
fix(datetime): fix range start/end text color specificity in ionic theme
OS-susmitabhowmik 4bffcb8
chore(): add updated snapshots
Ionitron d0d3f5c
Merge branch 'next' into ROU-12704-datepicker-range
OS-susmitabhowmik f7a9816
fix(datetime-button): normalize range values to chronological order
OS-susmitabhowmik fe95c5d
fix(datetime): check monthValues and yearValues in range disabled dat…
OS-susmitabhowmik 1097e45
style(datetime): add braces to early returns in getRangeValueArray
OS-susmitabhowmik 9c2609d
refactor(datetime): consolidate range start/end SCSS into single sele…
OS-susmitabhowmik a44b494
Revert "refactor(datetime): consolidate range start/end SCSS into sin…
OS-susmitabhowmik 5dc1f15
refactor(datetime): consolidate range start/end SCSS across all themes
OS-susmitabhowmik d4e9b20
fix(datetime): reduce range background opacity to 0.12 for md and ios
OS-susmitabhowmik c2deb03
fix(datetime): remove in-range day styles that hide focus indicator
OS-susmitabhowmik 959ae20
test(datetime): add screenshot test for focused in-range day
OS-susmitabhowmik 5680ea2
fix(datetime): preserve today styling inside range for md and ios
OS-susmitabhowmik c2a4cbe
fix(datetime): remove weekday from range header text
OS-susmitabhowmik fe907f6
fix(datetime): extend range track to calendar edge on wrapping rows
OS-susmitabhowmik 8d19452
fix(datetime): stay on end date month after completing cross-month range
OS-susmitabhowmik 9a7e61c
fix(datetime): include range parts on adjacent days for ::part() styling
OS-susmitabhowmik 1283fb4
test(datetime): verify adjacent days in range get part attributes
OS-susmitabhowmik 52747da
fix(datetime): use grid opacity for disabled range in ionic theme
OS-susmitabhowmik caeea84
refactor(datetime): move multiple mode wheel test to test/multiple
OS-susmitabhowmik 8ce83b5
fix(datetime): strengthen disabled date range test assertion
OS-susmitabhowmik 4c205cb
fix(datetime): strengthen range reset test assertion
OS-susmitabhowmik caa2621
test(datetime): use exact string match for range header text
OS-susmitabhowmik 68d1f01
refactor(datetime): remove duplicate RTL range screenshot test
OS-susmitabhowmik 5fe2655
refactor(datetime): merge ionChange event detail check into range test
OS-susmitabhowmik e5d74be
test(datetime): add cross-month range test
OS-susmitabhowmik 6e0b326
fix(datetime): hide range track for start-only partial range
OS-susmitabhowmik 8300dd6
test(datetime): verify confirm button disabled for incomplete range
OS-susmitabhowmik 4fcca91
test(datetime): verify reset with date clears range and navigates
OS-susmitabhowmik f7e0c96
feat(datetime): add aria-live announcement and in-range label for a11y
OS-susmitabhowmik 1cdae40
Revert "feat(datetime): add aria-live announcement and in-range label…
OS-susmitabhowmik 2ee1667
feat(datetime): add aria-live announcement and in-range label for a11y
OS-susmitabhowmik 11cac83
chore(toolbar): remove unrelated snapshot to be regenerated from next
OS-susmitabhowmik e061223
docs(datetime): simplify range-track part description
OS-susmitabhowmik b4bee49
style(datetime): remove trailing newline in range test file
OS-susmitabhowmik ed1dfdd
fix(datetime): fix monthValues range test to not assert on off-screen…
OS-susmitabhowmik 3c52058
fix(datetime): scope adjacent days test locator to visible month
OS-susmitabhowmik 09ac2a5
style(datetime): fix line length formatting in processValue
OS-susmitabhowmik f0802b6
fix(datetime): use month header assertion for cross-month range test
OS-susmitabhowmik 4d713d4
fix(datetime): skip navigation on complete range to prevent month jump
OS-susmitabhowmik 379534a
fix(datetime): use flag to skip navigation on interactive range compl…
OS-susmitabhowmik 63cfd1b
fix(datetime): use fixture.goto for cross-month range test
OS-susmitabhowmik 9a5de97
fix(datetime): simplify cross-month range test setup
OS-susmitabhowmik a8edc11
fix(datetime): wait for month scroll to settle in cross-month range test
OS-susmitabhowmik 12dfdf7
chore(): add updated snapshots
Ionitron b4387fb
chore(datetime): delete CI-generated snapshots for regeneration
OS-susmitabhowmik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.calendar-month-gridpadding. The MD2 date range picker runs the band to the edge on those rows, so the range reads as one band from week to week..calendar-bodyclips overflow, so the edge days can extend their::beforeinto it.Each theme then sets the overflow to its grid padding, next to
--range-track-height. The ionic theme keeps the0pxfallback.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! Fixed in fe907f6