Repository navigation
fix unittest - #3278
fix unittest#3278
Conversation
|
你好!感谢你反馈的问题/bug,但是你的描述好像是空的,我们需要你完整的信息,这样才能帮你解决问题 如果不知道怎么写,在新建issue的时候有若干个模板可供选择,祝好! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3278 +/- ##
=======================================
Coverage 88.70% 88.70%
=======================================
Files 158 158
Lines 29780 29805 +25
=======================================
+ Hits 26415 26440 +25
Misses 3365 3365 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
a1e6400 to
7210e24
Compare
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified in the test-setup and assertion changes.
No open issues 🎉
What changed in this PR
This PR fixes unit-test setup and strengthens assertions without changing production code.
Changes:
- Mock table metadata, descriptions, indexes, and creation SQL; verify the full response and engine calls.
- Replace the service’s connection reference with a test stub instead of modifying the underlying connection object.
| File | Description |
|---|---|
sql/tests.py |
Updates table-info mocks and adds response and call assertions. |
sql/test_services.py |
Isolates connection mocking in the successful-query test. |
Review effort: Balanced
No description provided.