Skip to content

fix unittest - #3278

Merged
hhyo merged 1 commit into
hhyo:masterfrom
LeoQuote:feat_upgrade_base
Nov 20, 2026
Merged

hhyo merged 1 commit into
hhyo:masterfrom
LeoQuote:feat_upgrade_base

Conversation

@LeoQuote

Copy link
Copy Markdown
Collaborator

No description provided.

@request-info

request-info Bot commented Nov 20, 2026

Copy link
Copy Markdown

你好!感谢你反馈的问题/bug,但是你的描述好像是空的,我们需要你完整的信息,这样才能帮你解决问题 如果不知道怎么写,在新建issue的时候有若干个模板可供选择,祝好!

@codecov

codecov Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.70%. Comparing base (ccc7134) to head (7210e24).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3278   +/-   ##
=======================================
  Coverage   88.70%   88.70%           
=======================================
  Files         158      158           
  Lines       29780    29805   +25     
=======================================
+ Hits        26415    26440   +25     
  Misses       3365     3365           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LeoQuote
LeoQuote marked this pull request as ready for review November 20, 2026 06:05
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T06:07:14.926375Z 7210e24 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified in the test-setup and assertion changes.

No open issues 🎉

What changed in this PR

This PR fixes unit-test setup and strengthens assertions without changing production code.

Changes:

  • Mock table metadata, descriptions, indexes, and creation SQL; verify the full response and engine calls.
  • Replace the service’s connection reference with a test stub instead of modifying the underlying connection object.
File Description
sql/​tests.py Updates table-info mocks and adds response and call assertions.
sql/​test_services.py Isolates connection mocking in the successful-query test.

Review effort: Balanced

@hhyo
hhyo merged commit f36dabb into hhyo:master Nov 20, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants