Repository navigation
Conversation
rxvt-unicode answers an OSC 10/11 color query with rgba:<red>/<green>/<blue>/<alpha> when the color isn't opaque (its process_color_seq, in builds with Xft). RgbColor's FromStr rejected that form, so the parser emitted no event for the answer at all. Accept it with exactly four channels, each 1 to 4 hex digits as for rgb:. The alpha channel must be valid but is dropped, as xterm-color does: the color actually seen depends on whatever shows through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rxvt-unicode answers an OSC 10/11 color query with
rgba:<red>/<green>/<blue>/<alpha>when the color isn't opaque (process_color_seqin itssrc/command.C, in builds with Xft).RgbColor'sFromStraccepted onlyrgb:and#…, so the parser emitted no event for such a reply at all.This accepts
rgba:with exactly four channels, each 1 to 4 hex digits as forrgb:. The alpha channel must be valid but is dropped, as the xterm-color crate does: the color actually seen depends on whatever shows through.Tests cover
FromStrwith anrgba:color, malformedrgba:strings (three or five channels, an empty or invalid alpha, a five-digit channel), and an OSC 11 reply withrgba:through the parser.