Skip to content

Prevent parser deadlock on DA2/DA3 and unhandled CSI sequences - #32

Open
HalFrgrd wants to merge 1 commit into
helix-editor:masterfrom
HalFrgrd:fix-da2-deadlock
Open

HalFrgrd wants to merge 1 commit into
helix-editor:masterfrom
HalFrgrd:fix-da2-deadlock

Conversation

@HalFrgrd

@HalFrgrd HalFrgrd commented Oct 18, 2026 •

Copy link
Copy Markdown

Parses DA1, DA2, and DA3 responses into csi::Device::DeviceAttributes(()).

Bails on unhandled CSI ?, CSI >, and CSI = sequences once a CSI final byte is reached instead of returning Ok(None). Previously, returning Ok(None) on a complete unhandled sequence (such as Ghostty's DA2 response \x1b[>1;10;0c) caused Parser to treat the sequence as forever incomplete which swallowed all subsequent input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant