Repository navigation
✨ feat(modal): 開閉のアニメーションをモーショントークンで動かす - #381
Merged
touyou merged 2 commits intoNov 18, 2026
Merged
Conversation
|
Deployment failed for project sparkle-design with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
touyou
approved these changes
Nov 4, 2026
- パネルを animate-motion-pop-in / -out で動かし、下から出す(--motion-pop-from-y: 1) - 中身(Header・Body・Footer)は animate-motion-content-in で、パネルより遅れてフェードインする - duration-200 などの直書きをなくす - アニメーションのクラスと、時間を直書きしていないことのテストを追加 - CHANGELOG に追記 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
harukosugimoto
force-pushed
the
motion-component-modal-1102
branch
from
November 6, 2026 06:31
fbd0d9d to
4a13168
Compare
This was referenced Nov 6, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016SVVD7wjdNHeN8F7cqRc5t
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Modal のパネルのアニメーションを、
duration-200などの直書きからモーショントークン(--motion-*)に置き換えます。動きは Dialog(#380)と同じです。設計ガイドラインでも、Modal は Dialog と同じ「下から上へ」「Medium」です。animate-motion-pop-in:フェード(fade)と、下からの移動・拡大(move)を別々の時間と easing で動かすanimate-motion-pop-out:exit の時間と easing で消えるanimate-motion-content-in:パネルより遅れてフェードインスタックでの位置
この PR は Stacked PRs の stack #394 の 2 / 8 段目です(goodpatch/sparkle-design-internal#403)。
#380 Dialog → #381 Modal → #382 Tooltip → #383 Select → #385 Switch → #386 Tabs → #387 InlineMessage → #388 Toast
すぐ下は #380 です。差分はこの PR の分だけになっています。モーショントークンを含む CSS の生成し直しは、一番下の #380 に入っています。
下の PR がマージされたら、
gh stack rebase && gh stack pushで積み直します。2026-11-05 に main の最新の上へ積み直し、各段で型チェック・lint・テストが通ることを確認しました。依存関係とマージの順番(sparkle-variables#15 → sparkle-design-cli#122 のリリース → CSS の生成し直し)は #380 と同じです。
プレビュー(Storybook)
変更点
src/components/ui/modal/index.tsx:animate-in/zoom-in-95/duration-200などをanimate-motion-pop-in/-out、[--motion-pop-from-y:1]、*:animate-motion-content-inに置き換えsrc/components/ui/modal/index.test.tsx:新しいクラスと、時間を直書きしていないことのテストを追加CHANGELOG.md:Unreleased に追記中身の遅れは、Dialog と同じく直下の子要素に
*:で付けています。ラッパーを足すとflex flex-colと Body のスクロール(grow overflow-auto)の構造が変わるためです。検証
pnpm test:818 件成功(skip 10・todo 18 は既存)pnpm type-check:成功pnpm lint:新しい警告なし(既存の 2 件のみ)prefers-reduced-motion: reduceでは、移動と拡大がなくなり(変形なし)、フェードと中身の遅れだけが残ることも確認しました。🤖 Generated with Claude Code