Repository navigation
feat: add a site-wide footer - #208
Merged
Merged
Conversation
Nothing on the site linked to the playground, the book, the API, or Zulip from more than one page, and the licence was stated once, in a sentence on /contribute/. The footer collects those and travels with every page, which matters most on a phone, where the nav is behind the hamburger. Four columns - the brand, Learn, Project, and Community - over a bar with the licence, a per-page "Edit this page" link into this repo, and the JProfiler and IntelliJ thanks, which move here from the bottom of the home page. The columns wrap 2x2 rather than 2+1: the brand is last in the source and ordered first from md up, so nothing is left ragged on a narrow screen. The footer's internal entries derive from navLinks so a renamed route is changed once, and the build fails if a label goes missing rather than shipping undefined hrefs. The mark, previously inline in the navbar and needed again in the footer, becomes a shared component. .page becomes a flex column so the footer sits on the bottom edge of the card on short pages such as /404/. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Nothing on the site linked to the playground, the book, the API, or Zulip from more than one page each, and the licence was stated once, in a sentence on
/contribute/. The footer collects those and travels with every page — which matters most on a phone, where the nav is behind the hamburger.What
Four columns — the brand, Learn, Project, Community — over a bar carrying the licence, a per-page Edit this page link into this repo, and the JProfiler / IntelliJ thanks, which move here from the bottom of the home page.
order-md-first, so nothing is left ragged on a narrow screen.navLinks, so a renamed route is changed in one place; the lookup throws at build time if a label goes missing rather than shippingundefinedhrefs on every page. Blog is the deliberate exception — it points atblog.flix.devdirectly, like the rest of its column.src/components/FlixMark.astro..pagebecomes a flex column with.page > main { flex: 1 }, so the footer sits on the bottom edge of the card on short pages such as/404/instead of floating mid-card.Testing
npm run buildpasses and all 10 routes were checked in the built HTML: every link resolves, the Edit this page URL maps to the right file per route, and the footer's text nodes keep their spacing (the compiler strips whitespace between adjacent elements, so the one separator carries its own padding). Rendering was reviewed in the browser at desktop and narrow widths.Notes
smwhile the link columns switch atmd, so between 576–768px you get a single-row bar under a 2×2 grid. Left as-is; happy to align them.<nav>, and the three column headings addh2s to each page's outline.🤖 Generated with Claude Code