Repository navigation
INTER-2673: ci: stop passing unused npm token to release workflow - #220
Merged
Merged
Conversation
Publishing uses npm trusted publishing (OIDC), so NPM_AUTH_TOKEN is not needed.
Contributor
pnpm exec changesetto create a changeset. |
Contributor
Coverage report
Test suite run success43 tests passing in 15 suites. Report generated by 🧪jest coverage report action from cd51895 Show full coverage report
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the change removing the unused npm token mapping from the release workflow.
No open issues 🎉
What changed in this PR
Removes the unused npm token from the release workflow’s call to the shared workflow, which uses npm trusted publishing.
Changes:
- Stops passing
NPM_AUTH_TOKENwhile retaining both GitHub App private keys.
| File | Description |
|---|---|
.github/workflows/release.yml |
Removes the unused NPM_AUTH_TOKEN secret mapping. |
Review effort: Balanced
JuroUhlar
marked this pull request as ready for review
November 11, 2026 17:40
JuroUhlar
requested review from
TheUnderScorer,
ilfa and
mcnulty-fp
as code owners
November 11, 2026 17:40
mcnulty-fp
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
INTER-2673
Why
The release workflow publishes with npm trusted publishing, so it no longer passes an npm token it does not use.
Things to note
release.ymlalready setsuseTrustedPublishing: trueandid-token: write. The Vue and Angular release workflows already pass only the two GitHub App keys.dx-team-toolkitatv1),NPM_AUTH_TOKENis declaredrequired: false, so omitting it is valid.Verification
Read
release-sdk-changesets.ymlatv1: the only use of the secret isNPM_TOKEN: ${{ inputs.useTrustedPublishing && '' || secrets.NPM_AUTH_TOKEN }}, and with the secret not passed that value is empty. Not verified: a real release run, which only happens on merge tomain.Change outline
One secret removed from the call to the shared release workflow.
secrets: APP_PRIVATE_KEY: ${{ secrets.APP_PRIVATE_KEY }} RUNNER_APP_PRIVATE_KEY: ${{ secrets.RUNNER_APP_PRIVATE_KEY }} - NPM_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}